Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Ensure APM deprecation documentationUrl point to correct doc branch #114756

Closed
sorenlouv opened this issue Oct 13, 2021 · 2 comments · Fixed by #115401
Closed

[APM] Ensure APM deprecation documentationUrl point to correct doc branch #114756

sorenlouv opened this issue Oct 13, 2021 · 2 comments · Fixed by #115401
Assignees
@cauemarcondes
Labels
apm:test-plan-7.16.0 apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v7.16.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Oct 13, 2021 •
edited by dannycroft
Loading

Carry-over from: #114263

Currently the documentationUrl points to current version:

kibana/x-pack/plugins/apm/server/deprecations/index.ts

Lines 49 to 50 in 0bf0b94

documentationUrl:
'https://www.elastic.co/guide/en/apm/server/current/apm-integration.html',

It should point to 7.16 (on 7.x) and 8.0 (on master)

For additional information see #114263 or reach out to @watson.
@sorenlouv sorenlouv added [zube]: 7.16 Team:APM All issues that need APM UI Team support labels Oct 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes self-assigned this Oct 15, 2021
@cauemarcondes cauemarcondes mentioned this issue Oct 18, 2021
Merged
@cauemarcondes
Copy link
Contributor

Tests okay:
Screen Shot 2021-10-20 at 2 34 39 PM
Screen Shot 2021-10-20 at 2 35 27 PM

@cauemarcondes cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
apm:test-plan-7.16.0 apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Ensure APM deprecation documentationUrl point to correct doc branch cauemarcondes/kibana
5 participants
@dannycroft @sorenlouv @ogupte @elasticmachine @cauemarcondes