Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Fix handling of body-less meta engine responses #115043

Merged
merged 1 commit into from
Oct 15, 2021
Merged

[App Search] Fix handling of body-less meta engine responses #115043

merged 1 commit into from
Oct 15, 2021

Conversation

orhantoy
Copy link
Contributor

Summary

The issue is that we're trying to parse the JSON response body when in fact we don't return a response body. See recording:

CleanShot.2021-10-14.at.17.36.29.mp4

XHR response:

{"statusCode":502,"error":"Bad Gateway","message":"Error connecting to Enterprise Search: invalid json response body at http://localhost:3002/as/engines/m1/source_engines/bulk_create reason: Unexpected end of JSON input"}

Kibana logs:

[2021-10-14T17:35:23.745+02:00][ERROR][plugins.enterpriseSearch] Error connecting to Enterprise Search: invalid json response body at http://localhost:3002/as/engines/m1/source_engines/bulk_create reason: Unexpected end of JSON input

Checklist

@orhantoy orhantoy added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins v7.15.2 v7.16.0 labels Oct 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@orhantoy orhantoy marked this pull request as ready for review October 14, 2021 18:28
@orhantoy orhantoy requested review from a team and byronhulcher October 14, 2021 18:28
@orhantoy orhantoy added the release_note:skip Skip the PR/issue when compiling release notes label Oct 15, 2021
@orhantoy orhantoy merged commit 8636d6b into elastic:master Oct 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
…#115043)

The issue is that we're trying to parse the JSON response body when in fact we don't return a response body.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
…#115043)

The issue is that we're trying to parse the JSON response body when in fact we don't return a response body.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x
7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 15, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#115187)

The issue is that we're trying to parse the JSON response body when in fact we don't return a response body.

Co-authored-by: Orhan Toy <toyorhan@gmail.com>
kibanamachine added a commit that referenced this pull request Oct 15, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#115186)

The issue is that we're trying to parse the JSON response body when in fact we don't return a response body.

Co-authored-by: Orhan Toy <toyorhan@gmail.com>
@orhantoy orhantoy deleted the fix-meta-engine-responses-without-json-response branch December 7, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.15.2 v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants