[App Search] Fix handling of body-less meta engine responses (#115043) (

#115187) The issue is that we're trying to parse the JSON response body when in fact we don't return a response body. Co-authored-by: Orhan Toy <[email protected]>
elastic · Oct 15, 2021 · c1b8d5e · c1b8d5e
1 parent d18687f
commit c1b8d5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/x-pack/plugins/enterprise_search/server/routes/app_search/source_engines.test.ts b/x-pack/plugins/enterprise_search/server/routes/app_search/source_engines.test.ts
@@ -92,6 +92,7 @@ describe('source engine routes', () => {
     it('creates a request to enterprise search', () => {
       expect(mockRequestHandler.createRequest).toHaveBeenCalledWith({
         path: '/as/engines/:name/source_engines/bulk_create',
+        hasJsonResponse: false,
       });
     });
   });
@@ -145,6 +146,7 @@ describe('source engine routes', () => {
     it('creates a request to enterprise search', () => {
       expect(mockRequestHandler.createRequest).toHaveBeenCalledWith({
         path: '/as/engines/:name/source_engines/:source_engine_name',
+        hasJsonResponse: false,
       });
     });
   });

diff --git a/x-pack/plugins/enterprise_search/server/routes/app_search/source_engines.ts b/x-pack/plugins/enterprise_search/server/routes/app_search/source_engines.ts
@@ -45,6 +45,7 @@ export function registerSourceEnginesRoutes({
     },
     enterpriseSearchRequestHandler.createRequest({
       path: '/as/engines/:name/source_engines/bulk_create',
+      hasJsonResponse: false,
     })
   );
 
@@ -60,6 +61,7 @@ export function registerSourceEnginesRoutes({
     },
     enterpriseSearchRequestHandler.createRequest({
       path: '/as/engines/:name/source_engines/:source_engine_name',
+      hasJsonResponse: false,
     })
   );
 }