[QA][refactor] Use ui settings - discover histogram

[wayneseymour]

[skip-ci]

Use ui settings instead of setting absolute range
for timepicker.

Helps with: [meta] [refactor] use ui settings instead of timepicker ui

[wayneseymour]

Runs fine on my local, so running on the flaky runner 40x:

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/89#fccfee81-8ed6-4fae-bc88-b338b1ae0fec

[wayneseymour]

I noticed the following while debugging this test on my local:

       │ debg browser[WARNING] http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js 4843:20 "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
       │      Arguments:
       │      [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: Jan 1, 2010 @ 00:00:00.000, _f: undefined, _strict: undefined, _locale: [object Object]
       │      Error
       │          at Function.createFromInputFallback (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:4880:25)
       │          at configFromString (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:7097:19)
       │          at configFromInput (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:7539:13)
       │          at prepareConfig (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:7522:13)
       │          at createFromConfig (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:7489:44)
       │          at createLocalOrUTC (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:7583:16)
       │          at createLocal (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:7587:16)
       │          at hooks (http://localhost:5620/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:4577:29)
       │          at Object.parse (http://localhost:5620/9007199254740991/bundles/plugin/data/kibana/data.plugin.js:1042:12)
       │          at validateTimeRange (http://localhost:5620/9007199254740991/bundles/plugin/data/kibana/data.plugin.js:38075:83)"

There are 5 it blocks in this test, and they all have this warning.

This makes sense, because before this pr, the ui was used to set the time.

Without a time format, and in strict mode, the time strings are not valid:

With a time format, and in strict mode, they are valid:

I got the correct format from the documentation of setAbsoluteRange in the time_picker page object.
I'll be following up soon.

[wayneseymour]

Looks like the parse fn is here: https://github.com/elastic/kibana/blob/master/packages/elastic-datemath/src/index.ts#L57

[wayneseymour]

Seems best to:

• Investigate whether it's best to format before calling PageObjects.common.setTime({ from, to })
  • since the ui settings call is an http request, I think we'd need to modify a very general request...injecting a condition where it probably should not live

[wayneseymour]

ci grp 6, 40x: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/96#5969a17d-b0b5-4005-b79f-63ed2c43b067

[wayneseymour]

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/114#ee984a55-ce5c-4086-8150-9332fc6f97d2

[wayneseymour]

ci grp 6 40x

[wayneseymour]

ci grp 6 40x

Hrmm, had one failure

[wayneseymour]

40x again: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/217

@LeeDr update: no failures on that run ^

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 76745be
• Storybooks Preview

Test Failures

• [job] [logs] Default CI Group #8 / performance reporting dashbaord downloaded PDF has OK status

Metrics [docs]

✅ unchanged

History

• 💚 Build #4281 succeeded 6a058d0
• 💛 Build #2780 was flaky 470199e
• 💔 Build #2125 failed a6f3d42
• 💔 Build #2036 failed 5a866cb
• 💔 Build #1848 failed 5542bd5
• 💔 Build #1332 failed 35fa1b5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

[kertal]

Refactoring LGTM, didn't test

[LeeDr]

Not having to do with this PR, but I'm really disappointed in the names of the first 3 tests vs what they are actually verifying. The make changed to the timepicker and then only verify that the chart exists. They don't verify the chart is showing the correct data or any data at all.

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	8.0
✅	7.16

The backport PRs will be merged automatically after passing CI.