[QA][refactor] Use ui settings - sample data #114530

wayneseymour · 2021-10-11T16:56:25Z

[skip-ci]

Use ui settings instead of setting absolute range
for timepicker.

Add 2 time functions to the common page,
set the time, unset the time.
The user handles their own navigation.

Helps with: #113998

wayneseymour · 2021-10-11T16:59:17Z

buildkite, test this

wayneseymour · 2021-10-11T17:53:06Z

buildkite, test this

wayneseymour · 2021-10-11T19:02:43Z

buildkite, test this

wayneseymour · 2021-10-11T19:31:35Z

@elasticmachine merge upstream

wayneseymour · 2021-10-12T14:54:08Z

@elasticmachine merge upstream

wayneseymour · 2021-10-12T17:33:02Z

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2004/

test/functional/apps/home/_sample_data.ts

Use ui settings instead of setting absolute range for timepicker. Stack this pr on top of: #114530 ...to use the new common page time fns.

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

test/functional/page_objects/common_page.ts

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

Use ui settings instead of setting absolute range for timepicker. Stack this pr on top of: #114530 ...to use the new common page time fns.

dmlemeshko

LGTM as long as Jenkins passes.

kibanamachine · 2021-10-19T10:29:04Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #428 succeeded b46777a
💔 Build #427 failed f7d24fe
💔 Build #413 failed 69cfacc
💔 Build #323 failed f5cb610
💚 Build #239 succeeded b65677b
💔 Build #192 failed 9fc9480

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

wayneseymour · 2021-10-19T10:31:21Z

It passed the flaky runner again too

…

On Tue, Oct 19, 2021, 11:29 AM Kibana Machine ***@***.***> wrote: 💚 Build Succeeded - Buildkite Build <https://buildkite.com/elastic/kibana-pull-request/builds/469> - Commit: 6b0ac9b <6b0ac9b> - Storybooks Preview <https://ci-artifacts.kibana.dev/storybooks/pr-114530/6b0ac9b5cfd132d9175ade71de8da277ce3c4a8f> Metrics [docs <https://www.elastic.co/guide/en/kibana/master/ci-metrics.html>] ✅ unchanged History - 💚 Build #428 <https://buildkite.com/elastic/kibana-pull-request/builds/428> succeeded b46777a <b46777a> - 💔 Build #427 <https://buildkite.com/elastic/kibana-pull-request/builds/427> failed f7d24fe <f7d24fe> - 💔 Build #413 <https://buildkite.com/elastic/kibana-pull-request/builds/413> failed 69cfacc <69cfacc> - 💔 Build #323 <https://buildkite.com/elastic/kibana-pull-request/builds/323> failed f5cb610 <f5cb610> - 💚 Build #239 <https://buildkite.com/elastic/kibana-pull-request/builds/239> succeeded b65677b <b65677b> - 💔 Build #192 <https://buildkite.com/elastic/kibana-pull-request/builds/192> failed 9fc9480 <9fc9480> To update your PR or re-run it, just comment with: @elasticmachine merge upstream cc @wayneseymour <https://github.com/wayneseymour> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#114530 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFCBQZYWD6LMJ7GIVMDOFLUHVB7XANCNFSM5FYVFWBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

kibanamachine · 2021-10-19T10:59:19Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 114530

# Conflicts: # test/functional/page_objects/common_page.ts

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

Use ui settings instead of setting absolute range for timepicker. Stack this pr on top of: #114530 ...to use the new common page time fns.

# Conflicts: # test/functional/page_objects/common_page.ts

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

* [QA][refactor] Use ui settings - discover histogram Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530 * Use TimeStrings interface.

* [QA][refactor] Use ui settings - discover histogram Use ui settings instead of setting absolute range for timepicker. Stacked on top of: elastic#114530 * Use TimeStrings interface.

* [QA][refactor] Use ui settings - discover histogram Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530 * Use TimeStrings interface. Co-authored-by: Tre <[email protected]>

* [QA][refactor] Use ui settings - discover histogram Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530 * Use TimeStrings interface.

wayneseymour added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 buildkite-ci labels Oct 11, 2021

wayneseymour mentioned this pull request Oct 11, 2021

[meta] [refactor] use ui settings instead of timepicker ui #113998

Closed

42 tasks

wayneseymour self-assigned this Oct 12, 2021

wayneseymour marked this pull request as ready for review October 12, 2021 18:44

wayneseymour requested review from LeeDr and dmlemeshko October 12, 2021 18:45

dmlemeshko reviewed Oct 13, 2021

View reviewed changes

test/functional/apps/home/_sample_data.ts Outdated Show resolved Hide resolved

wayneseymour requested a review from dmlemeshko October 13, 2021 15:50

wayneseymour force-pushed the refactor/timepicker-use-sample-data branch from b65677b to f5cb610 Compare October 14, 2021 13:08

wayneseymour added a commit that referenced this pull request Oct 14, 2021

[QA][refactor] Use ui settings - saved queries

2e4d41c

Use ui settings instead of setting absolute range for timepicker. Stack this pr on top of: #114530 ...to use the new common page time fns.

This was referenced Oct 14, 2021

[QA][refactor] Use ui settings - saved queries #114820

Merged

[QA][refactor] Use ui settings - discover histogram #114997

Merged

wayneseymour added a commit that referenced this pull request Oct 14, 2021

[QA][refactor] Use ui settings - discover histogram

2952863

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

dmlemeshko reviewed Oct 14, 2021

View reviewed changes

test/functional/page_objects/common_page.ts Outdated Show resolved Hide resolved

wayneseymour force-pushed the refactor/timepicker-use-sample-data branch from f5cb610 to 69cfacc Compare October 18, 2021 11:09

wayneseymour requested a review from dmlemeshko October 18, 2021 11:09

wayneseymour added a commit that referenced this pull request Oct 18, 2021

[QA][refactor] Use ui settings - discover histogram

f8346fc

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 18, 2021

[QA][refactor] Use ui settings - saved queries

f522f43

Use ui settings instead of setting absolute range for timepicker. Stack this pr on top of: #114530 ...to use the new common page time fns.

wayneseymour requested a review from dmlemeshko October 19, 2021 09:59

dmlemeshko approved these changes Oct 19, 2021

View reviewed changes

wayneseymour merged commit c1b0565 into master Oct 19, 2021

wayneseymour deleted the refactor/timepicker-use-sample-data branch October 19, 2021 10:56

wayneseymour mentioned this pull request Oct 19, 2021

[7.x] [QA][refactor] Use ui settings - sample data (#114530) #115549

Merged

wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Oct 19, 2021

[QA][refactor] Use ui settings - sample data (elastic#114530)

48fc9e7

# Conflicts: # test/functional/page_objects/common_page.ts

wayneseymour added a commit that referenced this pull request Oct 19, 2021

[QA][refactor] Use ui settings - discover histogram

682b64b

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 19, 2021

[QA][refactor] Use ui settings - saved queries

5b2f0dc

Use ui settings instead of setting absolute range for timepicker. Stack this pr on top of: #114530 ...to use the new common page time fns.

wayneseymour added a commit that referenced this pull request Oct 19, 2021

[QA][refactor] Use ui settings - sample data (#114530) (#115549)

00c6f11

# Conflicts: # test/functional/page_objects/common_page.ts

wayneseymour added a commit that referenced this pull request Oct 20, 2021

[QA][refactor] Use ui settings - discover histogram

3f73477

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 25, 2021

[QA][refactor] Use ui settings - discover histogram

35fa1b5

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 26, 2021

[QA][refactor] Use ui settings - discover histogram

df8a7e4

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 27, 2021

[QA][refactor] Use ui settings - discover histogram

2a8fb9c

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 27, 2021

[QA][refactor] Use ui settings - discover histogram

d0ab42f

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Oct 29, 2021

[QA][refactor] Use ui settings - discover histogram

470199e

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Nov 4, 2021

[QA][refactor] Use ui settings - discover histogram

fdab38a

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

wayneseymour added a commit that referenced this pull request Nov 15, 2021

[QA][refactor] Use ui settings - discover histogram

56fb343

Use ui settings instead of setting absolute range for timepicker. Stacked on top of: #114530

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QA][refactor] Use ui settings - sample data #114530

[QA][refactor] Use ui settings - sample data #114530

wayneseymour commented Oct 11, 2021 •

edited

Loading

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 12, 2021

wayneseymour commented Oct 12, 2021

dmlemeshko left a comment

kibanamachine commented Oct 19, 2021

wayneseymour commented Oct 19, 2021 via email

kibanamachine commented Oct 19, 2021

[QA][refactor] Use ui settings - sample data #114530

[QA][refactor] Use ui settings - sample data #114530

Conversation

wayneseymour commented Oct 11, 2021 • edited Loading

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 11, 2021

wayneseymour commented Oct 12, 2021

wayneseymour commented Oct 12, 2021

dmlemeshko left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 19, 2021

💚 Build Succeeded

Metrics [docs]

History

wayneseymour commented Oct 19, 2021 via email

kibanamachine commented Oct 19, 2021

💔 Backport failed

wayneseymour commented Oct 11, 2021 •

edited

Loading