Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix unhandled promise rejection failure #114883

Merged
merged 7 commits into from
Oct 19, 2021
Merged

[Uptime] Fix unhandled promise rejection failure #114883

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51595bd
Fix unhandled promise rejection failure.
justinkambic Oct 13, 2021
989a894
Mock monaco to avoid editor-related errors failing test.
justinkambic Oct 13, 2021
77c9fa8
Merge branch 'master' into 114687/fix-unhandled-promise-rejections
kibanamachine Oct 14, 2021
99a4b22
Merge master.
justinkambic Oct 15, 2021
13e87b5
Update assertion.
justinkambic Oct 15, 2021
53f6a06
Merge branch '114687/fix-unhandled-promise-rejections' of github.com:…
justinkambic Oct 15, 2021
3704643
Merge branch 'master' into 114687/fix-unhandled-promise-rejections
kibanamachine Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions x-pack/plugins/uptime/public/components/fleet_package/custom_fields.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,11 @@ describe.skip('<CustomFields />', () => {
// resolve errors
fireEvent.click(monitorType);

waitFor(() => {
expect(getByText('http')).toBeInTheDocument();
expect(getByText('tcp')).toBeInTheDocument();
expect(getByText('icmp')).toBeInTheDocument();
expect(queryByText('browser')).not.toBeInTheDocument();
await waitFor(() => {
justinkambic marked this conversation as resolved.
Show resolved Hide resolved
expect(getByText('HTTP')).toBeInTheDocument();
expect(getByText('TCP')).toBeInTheDocument();
expect(getByText('ICMP')).toBeInTheDocument();
expect(queryByText('Browser')).not.toBeInTheDocument();
});
});
});