-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Fix unhandled promise rejection failure #114883
[Uptime] Fix unhandled promise rejection failure #114883
Conversation
Pinging @elastic/uptime (Team:uptime) |
x-pack/plugins/uptime/public/components/fleet_package/custom_fields.test.tsx
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/fleet_package/custom_fields.test.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
…justinkambic/kibana into 114687/fix-unhandled-promise-rejections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboardStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* Fix unhandled promise rejection failure. * Mock monaco to avoid editor-related errors failing test. * Update assertion. Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Fix unhandled promise rejection failure. * Mock monaco to avoid editor-related errors failing test. * Update assertion. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Justin Kambic <[email protected]>
Summary
Resolves #114687. This issue is referenced in #112699.
If #110684 is merged before this PR then these tests will be skipped in
master
.Prevents an unhandled promise rejection. Adds a mock to Monaco for this file. There is some weirdness happening between tests. The final test will fail if all the preceding tests run, but not when it's run in isolation. I'm open to a different solution, but the mock seemed to fix it.
Testing
If you haven't already, install Node 16.11.1. On mac:
nvm install 16.11.1
Check with
node -v
, the output should bev16.11.1
. You should now be using the correct version, but if not,nvm use 16.11.1
.Then, run the tests in this PR. They should all pass.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers