Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development and build support for ARM based Apple devices #114879

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Development and build support for ARM based Apple devices #114879

merged 2 commits into from
Oct 19, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 13, 2021 •
edited
Loading

This adds *build and native development support for ARM based Apple devices.

Partially closes #83094, or closes if #109949 is resolved before merging.

@jbudz jbudz added release_note:enhancement Team:Operations Team label for Operations Team v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 buildkite-ci labels Oct 13, 2021
@jbudz

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@kibanamachine

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@jbudz jbudz changed the title Development and build support for ARM based Mac machines Development and build support for ARM based Apple devices Oct 17, 2021
@jbudz
Copy link
Member Author

jbudz commented Oct 17, 2021

n=1

~/dev/kibana-arm(ba6bf00df91) » node scripts/build_ts_refs --clean --no-cache --force                       jbudz@mini
 info deleting 197 ts output directories
 info Building TypeScript projects refs for tsconfig.refs.json...
 info [tsc] > node_modules/typescript/bin/tsc -b tsconfig.refs.json --pretty
 info [tsc] exited with 0 after 573.0 seconds
 succ ts refs build successfully
-----------------------------------------------------------------------------------------------------------------------
~/dev/kibana-arm(ba6bf00df91) » node scripts/build_kibana_platform_plugins.js                               jbudz@mini
 info initialized, 0 bundles cached
 warn only building [v8dark,v8light] themes, customize with the KBN_OPTIMIZER_THEMES environment variable
 info starting worker [47 bundles]
 info starting worker [47 bundles]
 info starting worker [47 bundles]
 info [27/141] initial bundle builds complete
 info [39/141] initial bundle builds complete
 info [48/141] initial bundle builds complete
 info [63/141] initial bundle builds complete
 info [78/141] initial bundle builds complete
 info [99/141] initial bundle builds complete
 info [104/141] initial bundle builds complete
 info [108/141] initial bundle builds complete
 info [113/141] initial bundle builds complete
 info [117/141] initial bundle builds complete
 info [123/141] initial bundle builds complete
 info [126/141] initial bundle builds complete
 info [129/141] initial bundle builds complete
 info [134/141] initial bundle builds complete
 succ 141 bundles compiled successfully after 168.9 sec

@jbudz jbudz marked this pull request as ready for review October 17, 2021 01:39
@jbudz jbudz requested a review from a team as a code owner October 17, 2021 01:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz
Development and build support for ARM based Apple devices
3a476f4 
This adds *build and native development support for ARM based Apple devices.

- Bazel has been updated to 4.2.1, providing ARM binaries
- Bazelisk has been updated to 1.10.1, providing ARM binaries
- *Reporting is disabled pending ARM binaries -  elastic#109949

Partially closes elastic#83094
@jbudz
Copy link
Member Author

jbudz commented Oct 19, 2021 •
edited
Loading

I cleaned up the commit history here and rebuilt node-re2 off the 1.16.0 tag instead of master branch. There were only docs / ci / test changes.

tylersmalley
tylersmalley approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, though I can't test since I don't have an Apple Silicon machine.

@jbudz jbudz enabled auto-merge (squash) October 19, 2021 19:23
@jbudz
Copy link
Member Author

jbudz commented Oct 19, 2021

@elasticmachine merge upstream

@jbudz jbudz merged commit fa1a233 into elastic:master Oct 19, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #505 failed 3a476f4
  • 💚 Build #404 succeeded ba6bf00df918c96ad0b550f3f2bfe08105aef6d2
  • 💔 Build #387 failed 44c77d1f601740a94c2d3245c5b6c7a1b72697a5
  • 💛 Build #357 was flaky 23851d705db07da517f379d50b4ccdd51a1ac32f
  • 💔 Build #352 failed 9ca5dd6f9dfd39727d4f40bb390105a791722fc7
  • 💔 Build #343 failed 8227b84b0d9b44c26d91ef68fc4b05d106c244f6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021
@jbudz @kibanamachine
Development and build support for ARM based Apple devices (elastic#11…
2bf08f4 
…4879)
@kibanamachine kibanamachine mentioned this pull request Oct 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@jbudz jbudz mentioned this pull request Oct 19, 2021
Closed
kibanamachine added a commit that referenced this pull request Oct 20, 2021
@kibanamachine @jbudz
Development and build support for ARM based Apple devices (#114879) (#…
b2e9b97 
…115663)

Co-authored-by: Jonathan Budzenski <[email protected]>
@tylersmalley tylersmalley mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed buildkite-ci ci:build-all-platforms release_note:enhancement Team:Operations Team label for Operations Team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate developer experience on ARM based Apple devices
5 participants
@jbudz @kibanamachine @elasticmachine @tylersmalley @mistic