-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] [Exploratory View] add chart creation context #114784
[Observability] [Exploratory View] add chart creation context #114784
Conversation
/oblt-deploy |
0762926
to
67ba076
Compare
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
…art type for synthetics data
…ps://github.com/dominiqueclarke/kibana into feature/exploratory-view-chart-creation-context
…ratory-view-chart-creation-context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes looks good !!
Things to consider.
- I think with panel it looked better, there was clear separation, now things looks mixed up
- Date format which is used to display range, contains too much information, upto ms, i know this is the drawback os using kibana default dateFormat, not sure how it can be improved.
Otherwise LGTM !!
The alternative is to hard code the date format. Wdyt? |
@elasticmachine merge upstream |
…ps://github.com/dominiqueclarke/kibana into feature/exploratory-view-chart-creation-context
@elasticmachine merge upstream |
…ps://github.com/dominiqueclarke/kibana into feature/exploratory-view-chart-creation-context
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboardStandard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…c#114784) * add chart creation context * add chart creation tooltip, remove outer panel, and change default chart type for synthetics data * adjust types * remove extra translations * add panel back * update chart creation time date format * update time format * adjust tests Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
… (#115704) * add chart creation context * add chart creation tooltip, remove outer panel, and change default chart type for synthetics data * adjust types * remove extra translations * add panel back * update chart creation time date format * update time format * adjust tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
Fixes #114867
Fixes #115352
Adds chart creation context.