Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespace for indices #114612

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Update namespace for indices #114612

merged 5 commits into from
Oct 13, 2021

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Oct 12, 2021 •
edited
Loading

Summary

Update namespace for indices in APM configuration settings.

Closes #114611.

@gbamparop gbamparop added release_note:fix Team:APM All issues that need APM UI Team support auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@gbamparop gbamparop requested a review from sorenlouv October 12, 2021 10:21
sorenlouv
sorenlouv approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please wait merging this until #113364 is merged

smith
smith requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the labels here in this PR, since that's what you see when you go to the settings: https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx#L31-L71

@sorenlouv
Copy link
Member

We should also update the labels here in this PR, since that's what you see when you go to the settings: master/x-pack/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx#L31-L71

That's what @ogupte is fixing in #113364

@ogupte
Copy link
Contributor

ogupte commented Oct 13, 2021

@gbamparop see the latest changes in my PR (#113364)

apm_oss.errorIndices -> xpack.apm.indices.error
apm_oss.metricsIndices -> xpack.apm.indices.metric
apm_oss.onboardingIndices -> xpack.apm.indices.onboarding
apm_oss.sourcemapIndices -> xpack.apm.indices.sourcemap
apm_oss.spanIndices -> xpack.apm.indices.span
apm_oss.transactionIndices -> xpack.apm.indices.transaction

These config changes are now final.

@ogupte ogupte enabled auto-merge (squash) October 13, 2021 05:24
@ogupte ogupte disabled auto-merge October 13, 2021 05:24
@gbamparop
Copy link
Contributor Author

Thanks @ogupte. I have updated the namespaces

@gbamparop gbamparop requested review from vigneshshanmugam and a team as code owners October 13, 2021 09:26
@gbamparop gbamparop requested a review from a team October 13, 2021 09:26
@gbamparop gbamparop requested review from a team as code owners October 13, 2021 09:26
@gbamparop gbamparop requested review from sorenlouv and smith and removed request for a team, vigneshshanmugam, joeypoon and parkiino October 13, 2021 09:30
@gbamparop gbamparop merged commit 767f007 into elastic:master Oct 13, 2021
@gbamparop gbamparop deleted the apm-update-configuration-settings branch October 13, 2021 14:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2021
@gbamparop @sorenlouv @kibanamachine
Update namespace for indices (elastic#114612)
fef005e 
* Update namespace for indices

* Update default index for transactions

Co-authored-by: Søren Louv-Jansen <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 13, 2021
@kibanamachine @gbamparop @sorenlouv
Update namespace for indices (#114612) (#114829)
7a9a427 
* Update namespace for indices

* Update default index for transactions

Co-authored-by: Søren Louv-Jansen <[email protected]>

Co-authored-by: Giorgos Bamparopoulos <[email protected]>
Co-authored-by: Søren Louv-Jansen <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reportingg/gu…
32c6f05 
…ide-users-to-saving-ux

* 'master' of github.com:elastic/kibana: (133 commits)
  [DOCS] Indicate reports are a subscription feature (elastic#114653)
  Update namespace for indices (elastic#114612)
  [DOCS] Adds Logstash pipeline settings (elastic#114648)
  Bump EPR snapshot version used for tests (elastic#114529)
  [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291)
  skip flaky suite (elastic#68400)
  [Visualizations] fix usage of optional dependencies (elastic#114286)
  [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454)
  [fleet] Add Integration Preference selector (elastic#114432)
  [Reporting] Add new `data-render-error` attribute (elastic#114472)
  Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316)
  [data views] add getDefaultDataView method  (elastic#113891)
  [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126)
  [fleet] Tweak Header UI (elastic#114704)
  [APM] Filter on tx metrics for instance stats (elastic#114758)
  [APM] Fix typo in linting docs (elastic#114764)
  [Discover] Removing SavedObject usage for savedSearch (elastic#112983)
  [Fleet] Add Integration Policy Page Improvements (elastic#114556)
  [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270)
  [Security Solution][Endpoint] Host Isolation API changes (elastic#113621)
  ...
bmorelli25
bmorelli25 reviewed Oct 13, 2021
View reviewed changes
docs/apm/troubleshooting.asciidoc
@@ -76,7 +76,7 @@ If you change the default, you must also configure the `setup.template.name` and
See {apm-server-ref}/configuration-template.html[Load the Elasticsearch index template].
If the Elasticsearch index template has already been successfully loaded to the index,
you can customize the indices that the APM app uses to display data.
Navigate to *APM* > *Settings* > *Indices*, and change all `apm_oss.*Pattern` values to
Navigate to *APM* > *Settings* > *Indices*, and change all `xpack.apm.*Pattern` values to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still figuring out my way around this change. Shouldn't this be xpack.apm.indices.*?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the fix to #114903.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this should have been removed instead, good spot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@smith smith smith approved these changes

@sorenlouv sorenlouv Awaiting requested review from sorenlouv

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM All issues that need APM UI Team support v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Update namespaces for APM configuration settings
7 participants
@gbamparop @elasticmachine @sorenlouv @ogupte @kibanamachine @smith @bmorelli25