Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualizations] fix usage of optional dependencies #114286

Merged
merged 5 commits into from
Oct 13, 2021
Merged

[Visualizations] fix usage of optional dependencies #114286

merged 5 commits into from
Oct 13, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 7, 2021 •
edited
Loading

Summary

This is a follow-up PR for #114128 that fixes any misuse of additional plugins from createGetterSetter across Kibana.

@alexwizp alexwizp self-assigned this Oct 7, 2021
@alexwizp alexwizp added v7.16.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Oct 7, 2021
@alexwizp alexwizp marked this pull request as ready for review October 7, 2021 14:09
@alexwizp alexwizp requested a review from a team as a code owner October 7, 2021 14:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@alexwizp
Copy link
Contributor Author

alexwizp commented Oct 7, 2021

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

VladLasitsa
VladLasitsa approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mbondyra
mbondyra approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 13, 2021
@alexwizp alexwizp enabled auto-merge (squash) October 13, 2021 11:54
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 38.9KB 38.9KB +3.0B
visualize 15.9KB 15.9KB +3.0B
total +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit ade369d into elastic:master Oct 13, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2021
@alexwizp @kibanamachine
[Visualizations] fix usage of optional dependencies (elastic#114286)
1c3b8bb 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reportingg/gu…
32c6f05 
…ide-users-to-saving-ux

* 'master' of github.com:elastic/kibana: (133 commits)
  [DOCS] Indicate reports are a subscription feature (elastic#114653)
  Update namespace for indices (elastic#114612)
  [DOCS] Adds Logstash pipeline settings (elastic#114648)
  Bump EPR snapshot version used for tests (elastic#114529)
  [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291)
  skip flaky suite (elastic#68400)
  [Visualizations] fix usage of optional dependencies (elastic#114286)
  [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454)
  [fleet] Add Integration Preference selector (elastic#114432)
  [Reporting] Add new `data-render-error` attribute (elastic#114472)
  Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316)
  [data views] add getDefaultDataView method  (elastic#113891)
  [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126)
  [fleet] Tweak Header UI (elastic#114704)
  [APM] Filter on tx metrics for instance stats (elastic#114758)
  [APM] Fix typo in linting docs (elastic#114764)
  [Discover] Removing SavedObject usage for savedSearch (elastic#112983)
  [Fleet] Add Integration Policy Page Improvements (elastic#114556)
  [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270)
  [Security Solution][Endpoint] Host Isolation API changes (elastic#113621)
  ...
kibanamachine added a commit that referenced this pull request Oct 13, 2021
@kibanamachine @alexwizp
[Visualizations] fix usage of optional dependencies (#114286) (#114811)
5805746 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @kibanamachine @mbondyra @VladLasitsa