Sets ES mapping to single_type=false #11451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail until elastic/elasticsearch#24317 is merged. |
jbudz
reviewed
Apr 26, 2017
|
Working on running the tests against the ES branch to verify |
tylersmalley
force-pushed
the
single-type-false
branch
3 times, most recently
from
9067a78 to
47919f3
Compare
|
You should be able to run the tests against master now. |
Until we are able to remove our usage of types, we need to disable this breaking change. Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
single-type-false
branch
from
47919f3 to
c3be95b
Compare
jbudz
approved these changes
May 3, 2017
There was a problem hiding this comment.
I ran tests locally against elastic/elasticsearch#24428. I had some failures on the integration tests, but it looks unrelated. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we can remove our use of types, we need to disable this breaking change.