Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround the dashboards' reliance on types #4218

Merged
merged 1 commit into from
May 5, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented May 4, 2017

Kibana still relies on types, and works around it by setting index.mapping.single_type=false
when creating the .kibana index. If the Beats dashboards are inserted before this index
is created, however, the import will fail. This adds single_type=false when creating the
.kibana index.

This is a temporary solution until Kibana removes types from its usage and we have an API
to index the dashboards.

This was inspired by elastic/kibana#11451 and should fix our failing integration tests.

Kibana still relies on types, and works around it by setting `index.mapping.single_type=false`
when creating the `.kibana` index. If the Beats dashboards are inserted before this index
is created, however, the import will fail. This adds `single_type=false` when creating the
`.kibana` index.

This is a temporary solution until Kibana removes types from its usage and we have an API
to index the dashboards.
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for green.

@andrewkroh andrewkroh merged commit 3a0d1db into elastic:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants