[Cases] [104932] Remove newline characters from summary field and add tests #113571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamster10
added
release_note:fix
v8.0.0
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases) |
|
@elasticmachine merge upstream |
cnasikas
reviewed
Oct 1, 2021
| const trimAndRemoveNewlines = (str: string) => | ||
| str | ||
| .split(/[\n\r]/gm) | ||
| .filter((item) => !isEmpty(item.trim())) |
There was a problem hiding this comment.
nit: if we swap the two operations we can get away with the second trim call.
.map((item) => item.trim())
.filter((item) => !isEmpty(item))
There was a problem hiding this comment.
good point, @jamster10 I'd add Christos' suggestion.
cnasikas
changed the title
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jamster10 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2021
… tests (elastic#113571) * [104932] Remove newline characters from summary field and add tests * PR fix Co-authored-by: Kristof-Pierre Cummings <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2021
… tests (elastic#113571) * [104932] Remove newline characters from summary field and add tests * PR fix Co-authored-by: Kristof-Pierre Cummings <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2021
… tests (#113571) (#113669) * [104932] Remove newline characters from summary field and add tests * PR fix Co-authored-by: Kristof-Pierre Cummings <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kristof C <[email protected]> Co-authored-by: Kristof-Pierre Cummings <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2021
… tests (#113571) (#113668) * [104932] Remove newline characters from summary field and add tests * PR fix Co-authored-by: Kristof-Pierre Cummings <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kristof C <[email protected]> Co-authored-by: Kristof-Pierre Cummings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #104932
Summary
Prevent summary field from having newline characters and extraneous spaces by trimming and removing said characters.
Description with multlines
Jira ticket summary created from multiline rule description ({{context.rule.description}})
Release notes
Reformatting Jira summary field to be one line