Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Jira action fails when newline symbol is in summary #104932

Closed
Dosant opened this issue Jul 8, 2021 · 5 comments · Fixed by #113571
Closed

[Actions] Jira action fails when newline symbol is in summary #104932

Dosant opened this issue Jul 8, 2021 · 5 comments · Fixed by #113571
Assignees
@jamster10
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 8, 2021

Found during 7.14 testing spike

If try to execute Jira action with a newline character, then it fails:

an error occurred while running the action executor: [Action][Jira]: Unable to create incident. Error: Request failed with status code 400. Reason: The summary is invalid because it contains newline characters.

It is very easy get into this state by mistake, by using template variables that could have new lines inside values:

Screen Shot 2021-07-08 at 18 37 12

Maybe we could process summary field after running templating and remove new lines (maybe there are other Jira specific constraints for this field)
@Dosant Dosant added enhancement New value added to drive a business result Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Jul 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote added bug Fixes for quality problems that affect the customer experience UX Team:Threat Hunting Security Solution Threat Hunting Team and removed enhancement New value added to drive a business result labels Aug 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@pmuellr
Copy link
Member

pmuellr commented Aug 4, 2021

Interesting problem. We can't really check this, anywhere but in the connector, when it executes. And we don't want the execution to fail, just for this reason.

Seems like what we'll want to do is have the connector fix this at execution time, probably be removing the newline, or perhaps replacing with a semi-colon or similar.

@gmmorris gmmorris changed the title [Alerting] Jira action fails when newline symbol is in summary [Actions] Jira action fails when newline symbol is in summary Aug 11, 2021
@gmmorris gmmorris added loe:large Large Level of Effort loe:needs-research This issue requires some research before it can be worked on or estimated and removed loe:large Large Level of Effort labels Aug 11, 2021
@gmmorris gmmorris added the estimate:needs-research Estimated as too large and requires research to break down into workable issues label Aug 18, 2021
@gmmorris gmmorris removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 2, 2021
@gmmorris gmmorris mentioned this issue Sep 22, 2021
Closed
@cnasikas cnasikas added Team:Threat Hunting:Cases and removed UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Sep 22, 2021
@jamster10 jamster10 linked a pull request Sep 30, 2021 that will close this issue
[Cases] [104932] Remove newline characters from summary field and add tests #113571
Merged
@jamster10 jamster10 mentioned this issue Sep 30, 2021
Merged
@jamster10 jamster10 self-assigned this Sep 30, 2021
@cnasikas cnasikas added Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Cases labels Jan 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kobelb kobelb removed the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 31, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 31, 2022
@kobelb kobelb added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamster10 jamster10

Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] [104932] Remove newline characters from summary field and add tests
8 participants
@pmuellr @gmmorris @kobelb @mikecote @Dosant @cnasikas @elasticmachine @jamster10