Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Remove deprecated enabled settings from plugins. #113495

Merged
merged 23 commits into from
Oct 17, 2021
Merged

[Breaking] Remove deprecated enabled settings from plugins. #113495

merged 23 commits into from
Oct 17, 2021

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Sep 30, 2021 •
edited
Loading

[skip-ci]

Closes #89584

Summary

This is a follow up to remove the enabled plugin settings that were deprecated in #112602.

Note that before this merges, Cloud configs will need to be updated as they rely on some of the settings changed here.

Notes for reviewers

If you already reviewed #112602, this PR should come as no surprise as it is removing the configs we previously deprecated.

If you are pinged for a CODEOWNERS review, please verify the following:

  1. Check and make sure the enabled setting was removed from your plugin as expected.
  2. Check and make sure any references to your plugin's enabled setting have been removed from the docs.
  3. If (1) and (2) look good, approve the PR.
  4. As a follow-up, discuss an upgrade path with your team.

Changes

  • Removes enabled config options from plugins which had it added to their configSchema
  • Removes logic from core that implicitly adds an enabled option for plugins which did not have a configSchema defined
  • Updates integration tests that relied on the old settings
  • Updates docs & removes any references to the removed settings

Breaking Changes Docs

The ability for most plugins to be disabled using the {plugin_name}.enabled config option has been removed.

Some plugins, such as telemetry, newsfeed, reporting, and the various vis_type plugins will continue to support this setting, however the rest of the plugins that ship with Kibana will not. By default, any newly created plugins will not support this configuration unless it is explicitly added to the plugin's configSchema.

If you are currently using one of these settings in your Kibana config, please remove it before upgrading to 8.0. If you were using these settings to control user access to certain Kibana applications, we recommend leveraging Feature Controls instead.

@lukeelmers lukeelmers self-assigned this Sep 30, 2021
@lukeelmers lukeelmers mentioned this pull request Sep 30, 2021
Merged
@lukeelmers lukeelmers force-pushed the feat/remove-disableable-plugins branch 7 times, most recently from d4cd207 to 0f047bf Compare October 5, 2021 22:31
@kibanamachine

This comment has been minimized.

Sign in to view
@lukeelmers lukeelmers force-pushed the feat/remove-disableable-plugins branch from 0f047bf to f362563 Compare October 6, 2021 16:45
@lukeelmers lukeelmers mentioned this pull request Oct 6, 2021
Closed
100 tasks
@lukeelmers lukeelmers marked this pull request as ready for review October 6, 2021 20:44
@lukeelmers lukeelmers requested a review from a team as a code owner October 6, 2021 20:44
@lukeelmers lukeelmers requested a review from a team October 6, 2021 20:44
@lukeelmers lukeelmers requested review from a team as code owners October 6, 2021 20:44
@lukeelmers lukeelmers force-pushed the feat/remove-disableable-plugins branch from 2ddb88f to a7912a1 Compare October 15, 2021 15:05
@lukeelmers lukeelmers force-pushed the feat/remove-disableable-plugins branch from 62a67ad to 577400b Compare October 15, 2021 17:07
@lukeelmers
Copy link
Member Author

@elasticmachine run elasticsearch-ci/docs

@lukeelmers lukeelmers mentioned this pull request Oct 15, 2021
Merged
@lukeelmers
Copy link
Member Author

Turns out the docs failure was because there's a ./shared/settings.asciidoc file in the docs repo that links to some of the removed documentation pages. I merged a PR to fix it, so hopefully things work this time: elastic/docs#2247

@elasticmachine run elasticsearch-ci/docs

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers lukeelmers merged commit 94aa791 into elastic:master Oct 17, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 36.1KB 36.0KB -21.0B
osquery 7.7KB 7.6KB -116.0B
timelines 157.4KB 157.3KB -80.0B
total -217.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukeelmers

@lukeelmers lukeelmers deleted the feat/remove-disableable-plugins branch October 17, 2021 21:42
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 18, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/poc…
6b639dd 
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (237 commits)
  [Uptime] Added uptime query inspector panel (elastic#115170)
  [Osquery] Add packs (elastic#107345)
  [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188)
  [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671)
  skip flaky tests.  elastic#115308, elastic#115313
  [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495)
  skip flaky suite.  elastic#107057
  skip flaky tests. elastic#89052, elastic#113418, elastic#115304
  skip flaky test. elastic#113892
  Bump node to 16.11.1 (elastic#110684)
  [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742)
  skip flaky suite.  elastic#115130
  one line remove assert (elastic#115127)
  Fixes migration bug where I was deleting attributes (elastic#115098)
  [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal  (elastic#114214)
  [build] Dockerfile update (elastic#115237)
  Fixes Cypress flake cypress test (elastic#115270)
  Disable APM e2e tests
  log an invalid type for SO (elastic#115175)
  [Fleet] Don't auto upgrade policies for AUTO_UPDATE packages (elastic#115199)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/dashboard_app.tsx
#	src/plugins/dashboard/public/types.ts
#	x-pack/plugins/reporting/server/lib/layouts/print_layout.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 18, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
36426c6 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (287 commits)
  [Security Solution][Endpoint] Change `trustedAppByPolicyEnabled` flag to `true` by default (elastic#115264)
  [APM] generator: support error events and application metrics (elastic#115311)
  [kibanaUtils] Don't import full `semver` client side (elastic#114986)
  [RAC] Link inventory alerts to the right inventory view (elastic#113553)
  [Uptime] Added uptime query inspector panel (elastic#115170)
  [Osquery] Add packs (elastic#107345)
  [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188)
  [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671)
  skip flaky tests.  elastic#115308, elastic#115313
  [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495)
  skip flaky suite.  elastic#107057
  skip flaky tests. elastic#89052, elastic#113418, elastic#115304
  skip flaky test. elastic#113892
  Bump node to 16.11.1 (elastic#110684)
  [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742)
  skip flaky suite.  elastic#115130
  one line remove assert (elastic#115127)
  Fixes migration bug where I was deleting attributes (elastic#115098)
  [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal  (elastic#114214)
  [build] Dockerfile update (elastic#115237)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
@KOTungseth KOTungseth mentioned this pull request Nov 1, 2021
Merged
@mshustov mshustov mentioned this pull request Nov 29, 2021
Closed
@TinaHeiligers TinaHeiligers mentioned this pull request Mar 17, 2022
Closed
@afharo afharo mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottybollinger scottybollinger scottybollinger approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@yuliacech yuliacech yuliacech approved these changes

@jportner jportner jportner approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@spong spong spong approved these changes

@sebelga sebelga sebelga approved these changes

@mgiota mgiota mgiota approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@flash1293 flash1293 flash1293 approved these changes

@nchaulet nchaulet nchaulet approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@timroes timroes timroes approved these changes

@nreese nreese nreese approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@simianhacker simianhacker simianhacker approved these changes

Assignees

@lukeelmers lukeelmers

Labels
backport:skip This commit does not require backporting Breaking Change buildkite-ci Feature:Configuration Settings in kibana.yml Feature:Plugins release_note:breaking Team:APM All issues that need APM UI Team support Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

By default, a plugin should not be disable-able