[Advanced Settings] hide unknown uiSettings from the UI

[sherry-ger]

Kibana version:
7.9.3

Elasticsearch version:
7.9.3

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

After disabling reporting, the reporting setting xpackReporting:customPdfLogo is still visible and editable in Stack Management > Kibana > Advanced Settings > General

Expected behavior:
Since reporting is disabled, the setting should either be invisible or not editable.

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[legrego]

This is less of a reporting issue, and more an issue with the way Advanced Settings are managed. I'm going to relabel this as such.

@elastic/kibana-core do you know if we have valid use-cases for supporting "custom" (unknown) advanced settings in the API or UI? It's currently a feature today, because there's special handling to support these features. Is there still benefit to keeping this around, or can we consider changing the way this works?

I know that disabling/enabling plugins can change which settings are "custom", but we can keep existing settings around without allowing them to be re-configured, right?

[mshustov]

do you know if we have valid use-cases for supporting "custom" (unknown) advanced settings in the API or UI?

I don't see any technical argument to show them in UI when an owner plugin is disabled. @thesmallestduck @alexfrancoeur Do you see any reason to show and allow users to configure settings for disabled plugins?

[alexfrancoeur]

If it's disabled, I don't think we should show related configuration settings.

[pgayvallet]

If it's disabled, I don't think we should show related configuration settings.

TBH I assumed this was the behavior for the way I implemented the uiSettings for the banners plugin in #94449, so +1 to hide unknown settings from the UI.

[TinaHeiligers]

I'm going to rename this issue to make the title more descriptive of what changes we want to make.

[TinaHeiligers]

Scope here is to:

• either filter out unknown settings on the server (those that aren't explicitly registered)
• or add a label that a setting is unknown to hide it from the UI

[TinaHeiligers]

We removed support for disabling almost all plugins from Kibana as of 8.0. However, there are exceptions to this, with Reporting being one of them.