Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unksip and improve index pattern without time field functional test #112698

Merged
merged 6 commits into from
Sep 29, 2021
Merged

[Discover] Unksip and improve index pattern without time field functional test #112698

merged 6 commits into from
Sep 29, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Sep 21, 2021 •
edited
Loading

Summary

This PR unskips the "index pattern without time field" functional test suite in Discover. It was flaky, and this PR improves this.
Fixes #107057

Flaky test runner 100 runs:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1947/

Checklist

Delete any items that are not applicable to this PR.

@kertal kertal self-assigned this Sep 21, 2021
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 21, 2021
@rashmivkulkarni rashmivkulkarni mentioned this pull request Sep 22, 2021
Closed
38 tasks
@kertal
Copy link
Member Author

kertal commented Sep 27, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal changed the title [Discover] Harden functional test [Discover] Unksip and improve index pattern without time field functional test Sep 28, 2021
@kertal kertal added v7.14.3 v7.15.1 v7.16.0 backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Sep 28, 2021
@kertal kertal marked this pull request as ready for review September 28, 2021 08:10
@kertal kertal requested a review from a team as a code owner September 28, 2021 08:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 28, 2021
LeeDr
LeeDr approved these changes Sep 28, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code and Jenkins results review only

rashmivkulkarni
rashmivkulkarni reviewed Sep 28, 2021
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for hardening the test and also looks good on Flaky test runner.

LGTM

rashmivkulkarni
rashmivkulkarni approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kertal kertal requested a review from majagrubic September 29, 2021 09:50
timroes
timroes approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kertal kertal merged commit 8659f45 into master Sep 29, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@kertal @kibanamachine
[Discover] Unksip and improve index pattern without time field functi…
a59665a 
…onal test (elastic#112698)
@kibanamachine kibanamachine mentioned this pull request Sep 29, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@kertal @kibanamachine
[Discover] Unksip and improve index pattern without time field functi…
d5b95f0 
…onal test (elastic#112698)
This was referenced Sep 29, 2021
Merged
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@kertal @kibanamachine
[Discover] Unksip and improve index pattern without time field functi…
26b6468 
…onal test (elastic#112698)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.15
✅ 7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 29, 2021
@kibanamachine @kertal
[Discover] Unksip and improve index pattern without time field functi…
52113fb 
…onal test (#112698) (#113393)

Co-authored-by: Matthias Wilhelm <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 29, 2021
@kibanamachine @kertal
[Discover] Unksip and improve index pattern without time field functi…
548426d 
…onal test (#112698) (#113392)

Co-authored-by: Matthias Wilhelm <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 29, 2021
@kibanamachine @kertal
[Discover] Unksip and improve index pattern without time field functi…
f2fa26c 
…onal test (#112698) (#113391)

Co-authored-by: Matthias Wilhelm <[email protected]>
@spalger spalger deleted the kertal-pr-fix-another-functional branch May 8, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@rashmivkulkarni rashmivkulkarni rashmivkulkarni approved these changes

@timroes timroes timroes approved these changes

@majagrubic majagrubic Awaiting requested review from majagrubic

Assignees

@kertal kertal

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v7.14.3 v7.15.1 v7.16.0
Projects
None yet
Milestone
No milestone
6 participants
@kertal @kibanamachine @elasticmachine @timroes @rashmivkulkarni @LeeDr