Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip tests on 7.15 branch #110310

Closed
wants to merge 6 commits into from
Closed

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Aug 26, 2021

This PR unskips the following tests in 7.15 branch.
To find - grep -r ".skip(" test/functional/apps/* -B 1 — master
To replace - for i in find ./ -type f; do sed -i.bu "s|.skip(|(|g" $i; done

Under kibana/test/functional/apps:

  • test/functional/apps/dashboard/dashboard_filtering.ts: describe.skip('dashboard filtering', function () { [vega] Handle removal of deprecated date histogram interval #109090
  • test/functional/apps/dashboard/dashboard_unsaved_state.ts: describe.skip('dashboard unsaved panels', () => { ( This test is not skipped on master )
  • test/functional/apps/dashboard/embeddable_rendering.ts: describe.skip('dashboard embeddable rendering', function describeIndexTests() {
  • test/functional/apps/discover/_discover.ts: it.skip('should show ticks in the correct time zone after switching', async function () {
  • test/functional/apps/discover/_indexpattern_without_timefield.ts: describe.skip('indexpattern without timefield', () => { [Discover] Unksip and improve index pattern without time field functional test #112698)
  • test/functional/apps/discover/_data_grid_doc_table.ts: it.skip('should show popover with expanded cell content by click on expand button', async () => {
  • test/functional/apps/discover/_data_grid_doc_table.ts: it.skip('should show allow adding columns from the detail panel', async function () {
  • test/functional/apps/management/_index_pattern_create_delete.js: describe.skip('validation', function () {
  • test/functional/apps/management/_runtime_fields.js: describe.skip('runtime fields', function () {
  • test/functional/apps/management/_scripted_fields.js: it.skip('should sort scripted field value in Discover', async function () {
  • test/functional/apps/management/_scripted_fields.js: it.skip('should sort scripted field value in Discover', async function () {
  • test/functional/apps/management/_test_huge_fields.js: describe.skip('test large number of fields', function () { Unskip a functional test ( test_huge_fields.js)  #112878
  • test/functional/apps/management/_scripted_fields_preview.js: describe.skip('scripted fields preview', () => {
  • test/functional/apps/visualize/input_control_vis/chained_controls.ts: describe.skip('chained controls', function () {
  • test/functional/apps/visualize/input_control_vis/dynamic_options.ts: describe.skip('dynamic options', () =>
  • test/functional/apps/visualize/_metric_chart.ts: describe.skip('metric chart', function () {

Under x-pack/test/functional/apps:

  • test/functional/apps/dashboard/sync_colors.ts: describe.skip('sync colors', function () {
  • test/functional/apps/dashboard_mode/dashboard_empty_screen.js: describe.skip('empty dashboard', function () {
  • test/functional/apps/grok_debugger/home_page.ts: it.skip('applies the correct CSS classes', async () => { ( [ x-pack Functional] unskipping home_page.ts test.  #113312 - closed this test( comments in the PR)
  • test/functional/apps/infra/metrics_explorer.ts: describe.skip('Saved Views', () => {
  • test/functional/apps/infra/home_page.ts: describe.skip('Saved Views', () => { trying to fix the skipped test - infra-home-page test #113484
  • test/functional/apps/infra/feature_controls/index.ts: describe.skip('feature controls', function () {
  • test/functional/apps/maps/layer_errors.js: describe.skip('layer errors', () => {
  • test/functional/apps/maps/layer_errors.js: it.skip('should diplay error message in layer panel', async () => {
  • test/functional/apps/maps/feature_controls/maps_spaces.ts: describe.skip('spaces feature controls', () => { un-skip maps/feature_controls/maps_spaces.ts functional test #113656
  • test/functional/apps/ml/data_frame_analytics/feature_importance.ts: describe.skip(${testData.suiteTitle}, function () {
  • test/functional/apps/monitoring/setup/metricbeat_migration_mb.js: describe.skip('Setup mode metricbeat migration mb', function () {
  • test/functional/apps/monitoring/time_filter.js: it.skip('should send another request when changing the time picker', async () => {
  • test/functional/apps/monitoring/elasticsearch/indices_mb.js: it.skip('should show indices table with correct rows after sorting by Search Rate Desc', async () => {
  • test/functional/apps/monitoring/elasticsearch/nodes.js: describe.skip('with only online nodes', () => {
  • test/functional/apps/monitoring/elasticsearch/shards.js: describe.skip('Elasticsearch shard legends', () => {
  • test/functional/apps/monitoring/elasticsearch/indices.js: it.skip('should show indices table with correct rows after sorting by Search Rate Desc', async () => {
  • test/functional/apps/observability/feature_controls/observability_security.ts: it.skip(create new case returns a 403, async () => {
  • test/functional/apps/security/users.js: describe.skip('users', function () {
  • test/functional/apps/spaces/enter_space.ts: describe.skip('Enter Space', function () {
  • test/functional/apps/spaces/spaces_selection.ts: describe.skip('Spaces', function () {
  • test/functional/apps/upgrade_assistant/upgrade_assistant.ts: it.skip('allows user to navigate to upgrade checkup', async () - assigned to @cuff-links
  • test/functional/apps/uptime/locations.ts: describe.skip('Observer location', () => {

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 2, 2021

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 3, 2021

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Sep 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm
Copy link
Contributor Author

closing as this was never supposed to be merged.

@bhavyarm bhavyarm closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants