Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uptime] deep import to top level import for index_pattern item #112188

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[uptime] deep import to top level import for index_pattern item #112188

merged 1 commit into from
Sep 15, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Sep 14, 2021 •
edited
Loading

Summary

Converting some deep imports to top level imports. This removes references to 'index_patterns' which will make the conversion to data views easier.

Split from #112047

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime changed the title remove deep import [uptime] deep import to top level import for index_pattern item Sep 15, 2021
@mattkime mattkime added v7.16.0 v8.0.0 Team:AppServices auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Sep 15, 2021
@mattkime mattkime marked this pull request as ready for review September 15, 2021 12:10
@mattkime mattkime requested a review from a team as a code owner September 15, 2021 12:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

justinkambic
justinkambic approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@mattkime mattkime merged commit 5baa17d into elastic:master Sep 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 15, 2021
@mattkime @kibanamachine
remove deep import (elastic#112188)
439baa1
@kibanamachine kibanamachine mentioned this pull request Sep 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 15, 2021
@kibanamachine @mattkime
remove deep import (#112188) (#112280)
bab1c70 
Co-authored-by: Matthew Kime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattkime @kibanamachine @elasticmachine @justinkambic