-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] rename files from index patterns to data view #112047
[data views] rename files from index patterns to data view #112047
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
merge conflict between base and head |
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for core changes
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/saved_search_job·ts.machine learning anomaly detection saved search with lucene query job creation runs the job and displays it correctly in the job listStandard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, data discover code owner review. just one file changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test this locally, but happy if CI is green for app services changes 👍🏻
💔 Backport failed
To backport manually run: |
…12047) * rename directories Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/common/search/search_source/search_source.test.ts # src/plugins/data/public/data_views/data_views/on_unsupported_time_pattern.tsx # src/plugins/data/public/data_views/index.ts # src/plugins/data/server/search/search_service.ts
…112408) * rename directories Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/common/search/search_source/search_source.test.ts # src/plugins/data/public/data_views/data_views/on_unsupported_time_pattern.tsx # src/plugins/data/public/data_views/index.ts # src/plugins/data/server/search/search_service.ts
Summary
Renaming files and directories from
index_patterns
todata_views
. Also renamingdataViews.hasUserIndexPattern
todataViews.hasUserDataView
(indexPatterns
anddataViews
services are the same)Part of #103978 - larger renaming of index patterns to data views.