[Workplace Search] Fix confidential OAuth flow #111802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were accepting "string | undefined" as `state` parameter. But if the `state` was not present in the URL, we received null. That was breaking the confidential flow in cases where `state` was not provided. This commit changes the type of parameter to "string | null" and fixes the flow in such cases.
yakhinvadim
added
auto-backport
scottybollinger
approved these changes
Sep 9, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 9, 2021
Previously we were accepting "string | undefined" as `state` parameter. But if the `state` was not present in the URL, we received null. That was breaking the confidential flow in cases where `state` was not provided. This commit changes the type of parameter to "string | null" and fixes the flow in such cases.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 10, 2021
Previously we were accepting "string | undefined" as `state` parameter. But if the `state` was not present in the URL, we received null. That was breaking the confidential flow in cases where `state` was not provided. This commit changes the type of parameter to "string | null" and fixes the flow in such cases. Co-authored-by: Vadim Yakhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/elastic/workplace-search-team/issues/2010
Previously we were accepting "string | undefined" as
stateparameter.But if the
statewas not present in the URL, we actually received null.That was breaking the confidential flow in cases where
statewas not provided.This commit changes the type of parameter to "string | null" which fixes the flow in such cases.
Before:
(Authorize)
Screen.Cast.2021-09-09.at.5.07.03.PM.mp4
(Deny)
Screen.Cast.2021-09-09.at.5.06.50.PM.mp4
After:
(Authorize)
Screen.Cast.2021-09-09.at.4.41.36.PM.mp4
(Deny)
Screen.Cast.2021-09-09.at.5.01.02.PM.mp4
Checklist
Delete any items that are not applicable to this PR.
For maintainers