Fix confidential OAuth flow (#111802) (#111809)

Previously we were accepting "string | undefined" as `state` parameter. But if the `state` was not present in the URL, we received null. That was breaking the confidential flow in cases where `state` was not provided. This commit changes the type of parameter to "string | null" and fixes the flow in such cases. Co-authored-by: Vadim Yakhin <[email protected]>
elastic · Sep 10, 2021 · 9b6629a · 9b6629a
1 parent 07ef0b8
commit 9b6629a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/x-pack/plugins/enterprise_search/server/routes/workplace_search/oauth.ts b/x-pack/plugins/enterprise_search/server/routes/workplace_search/oauth.ts
@@ -26,7 +26,7 @@ export function registerOAuthAuthorizeRoute({
           response_mode: schema.maybe(schema.string()),
           redirect_uri: schema.maybe(schema.string()),
           scope: schema.maybe(schema.string()),
-          state: schema.maybe(schema.string()),
+          state: schema.nullable(schema.string()),
         }),
       },
     },
@@ -49,7 +49,7 @@ export function registerOAuthAuthorizeAcceptRoute({
           response_type: schema.string(),
           redirect_uri: schema.maybe(schema.string()),
           scope: schema.maybe(schema.string()),
-          state: schema.maybe(schema.string()),
+          state: schema.nullable(schema.string()),
         }),
       },
     },
@@ -72,7 +72,7 @@ export function registerOAuthAuthorizeDenyRoute({
           response_type: schema.string(),
           redirect_uri: schema.maybe(schema.string()),
           scope: schema.maybe(schema.string()),
-          state: schema.maybe(schema.string()),
+          state: schema.nullable(schema.string()),
         }),
       },
     },