Fix extra white space on the alert table when page size is 50 or 100 #111568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
added
v7.15.1
v8.0.0
Team: SecuritySolution
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @machadoum |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
machadoum
added
the
release_note:skip
angorayc
approved these changes
Sep 9, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 13, 2021
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (120 commits) [TSVB] Support custom field format (elastic#101245) [VisEditors] Add code ownership to the functional tests (elastic#111680) [Lens] Make Lens saved object share-capable (elastic#111403) [Graph] Make Graph saved object share-capable (elastic#111404) [Stack Monitoring] Add breadcrumb support (elastic#111850) Update Jira Cloud to use OAuth2.0 (elastic#111493) Show warning message when attempting to create an APM alert in stack management (elastic#111781) Skip suite blocking ES snapshot promotion (elastic#111907) Respect `auth_provider_hint` if session is not authenticated. (elastic#111521) Added in 'Responses' field in alert telemetry & updated test (elastic#111892) [Usage collection] refactor cloud detector collector (elastic#110439) Make classnames a shared dep (elastic#111636) Fix link to e2e tests in APM testing.md (elastic#111869) [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455) [APM] Removes the beta label from APM tutorial (elastic#111499) (elastic#111828) [RAC] [Observability] Expand Observability alerts page functional tests (elastic#111297) Fix extra white space on the alert table whe page size is 50 or 100 (elastic#111568) [Metrics UI] Add Inventory Timeline open/close state to context and URL state (elastic#111034) [Graph] Switch to SavedObjectClient.resolve (elastic#109617) [APM] Adding lambda icon (elastic#111834) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
machadoum
added
the
auto-backport
This was referenced Sep 14, 2021
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 14, 2021
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2021
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2021
…111568) (#112116) Co-authored-by: Pablo Machado <[email protected]>
machadoum
added a commit
that referenced
this pull request
Sep 14, 2021
machadoum
added a commit
that referenced
this pull request
Sep 14, 2021
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2021
…111568) (#112117) Co-authored-by: Pablo Machado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When selecting 50 or 100 items per page the table has some extra white space.
The bug also happens when filtering out the number of alerts in the table and then removing the filter.
It happens because the hack to calculate the height based on the content doesn't work when the table is smaller than the content. For some reason, DataGrid sets the inner height bigger than it should...
So, I added a hack on top of the hack. I hard-coded the size of the table for every page size. Then the calculation of the page height based on the content will only happen when
alertsQuantity < pageSize.FYI: This hack is a workaround to calculate alert table height while EUI team doesn't fix this bug: elastic/eui#5030