[RAC] [Observability] Expand Observability alerts page functional tests #111297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
…-and-date-picker-tests
…-and-date-picker-tests
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
reviewed
Sep 7, 2021
x-pack/test/observability_functional/apps/observability/alerts/index.ts
Outdated
Show resolved
Hide resolved
x-pack/test/observability_functional/apps/observability/alerts/index.ts
Outdated
Show resolved
Hide resolved
…-and-date-picker-tests
- Use flyout service - Use lower case "O" for observability - Better function naming
…-and-date-picker-tests
|
@weltenwort Thanks for the review |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Kerry350 |
| rangeFrom: '2021-08-31T13:36:22.109Z', | ||
| rangeTo: '2021-09-01T13:36:22.109Z', | ||
| }; | ||
| async function asyncForEach<T>(array: T[], callback: (item: T, index: number) => void) { |
There was a problem hiding this comment.
Is it important that these happen in sequence (versus in parallel with Promise.all)?
Further, this is a big repo but I imagine this has been needed before. How common is it to extract common helpers like this on repo or "team" level?
There was a problem hiding this comment.
We generally avoid extracting this type of stuff into repo level helpers. In the case that you want synchronous iteration I think that using a simple for...of loop makes the most sense.
for (const x of items) {
await fn(x)
}
machadoum
approved these changes
Sep 10, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 10, 2021
…ts (elastic#111297) * Regenerate data and add tests
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 13, 2021
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (120 commits) [TSVB] Support custom field format (elastic#101245) [VisEditors] Add code ownership to the functional tests (elastic#111680) [Lens] Make Lens saved object share-capable (elastic#111403) [Graph] Make Graph saved object share-capable (elastic#111404) [Stack Monitoring] Add breadcrumb support (elastic#111850) Update Jira Cloud to use OAuth2.0 (elastic#111493) Show warning message when attempting to create an APM alert in stack management (elastic#111781) Skip suite blocking ES snapshot promotion (elastic#111907) Respect `auth_provider_hint` if session is not authenticated. (elastic#111521) Added in 'Responses' field in alert telemetry & updated test (elastic#111892) [Usage collection] refactor cloud detector collector (elastic#110439) Make classnames a shared dep (elastic#111636) Fix link to e2e tests in APM testing.md (elastic#111869) [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455) [APM] Removes the beta label from APM tutorial (elastic#111499) (elastic#111828) [RAC] [Observability] Expand Observability alerts page functional tests (elastic#111297) Fix extra white space on the alert table whe page size is 50 or 100 (elastic#111568) [Metrics UI] Add Inventory Timeline open/close state to context and URL state (elastic#111034) [Graph] Switch to SavedObjectClient.resolve (elastic#109617) [APM] Adding lambda icon (elastic#111834) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2021
…ts (#111297) (#111867) * Regenerate data and add tests Co-authored-by: Kerry Gallagher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #110630 and #110634, regenerates the archive data, and unskips flakey tests.
Testing
Run:
node scripts/functional_tests_server --config x-pack/test/observability_functional/with_rac_write.config.tsRun:
node scripts/functional_test_runner --config x-pack/test/observability_functional/with_rac_write.config.ts --grep='Observability alerts'