Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): check for used dependencies on multiple level plugins #110626

Merged
merged 1 commit into from
Sep 1, 2021
Merged

chore(NA): check for used dependencies on multiple level plugins #110626

merged 1 commit into from
Sep 1, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 31, 2021 •
edited
Loading

It allows that task to search for server code on multiple depth levels instead of just one.

@mistic mistic mentioned this pull request Aug 31, 2021
Merged
@mistic mistic added auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0 labels Aug 31, 2021
@mistic mistic marked this pull request as ready for review August 31, 2021 14:50
@mistic mistic requested a review from a team as a code owner August 31, 2021 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz August 31, 2021 14:50
@tylersmalley
Copy link
Contributor

What caused this? Do we have nested plugins somewhere?

@mistic
Copy link
Member Author

mistic commented Aug 31, 2021

@tylersmalley yes, the majority of vis_type_x plugins are now vis_types/x

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit ff73025 into elastic:master Sep 1, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 1, 2021
@mistic @kibanamachine
chore(NA): check for used dependencies on multiple level plugins (ela…
5fbcfa7 
…stic#110626)
@kibanamachine kibanamachine mentioned this pull request Sep 1, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 1, 2021
@kibanamachine @mistic
chore(NA): check for used dependencies on multiple level plugins (#11…
8a8f9aa 
…0626) (#110745)

Co-authored-by: Tiago Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@jbudz jbudz Awaiting requested review from jbudz

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @tylersmalley @kibanamachine