Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to vis_types folder part 2 #110574

Merged
merged 10 commits into from
Sep 3, 2021
Merged

Move to vis_types folder part 2 #110574

merged 10 commits into from
Sep 3, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 31, 2021 •
edited
Loading

Part of #107500

This is the second part of moving all the vis_type_* plugins to a new folder vis_types.

In this PR three plugins are moved:

  • tagcloud
  • metric
  • vega

Changes in details are:

  • Moved the vis_type_tagcloud, vis_type_metric and vis_type_vega to a new folder vis_types (just a folder)
  • Remove the vis_type_ from the folder name. From now on they will be vega, tagcloud, metric. Important note: Only the folder names have changed and not the plugin ids.
  • All the relative paths have been updated
  • Updated all the kibana conf files (jest, tsconfig) to take under consideration the new paths

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elastic/kibana-operations I need your help :D
This PR just moves some plugins to a new folder vis_types (folder depth has increased by one).
CI fails with the error:

FATAL  Error: Cannot find module 'hjson'
     │ proc [kibana] Require stack:
     │ proc [kibana] - /dev/shm/workspace/kibana-build-22/src/plugins/vis_types/vega/server/usage_collector/get_usage_collector.js

when I comment out the import { parse } from 'hjson'; from the src/plugins/vis_types/vega/server/usage_collector/get_usage_collector.js, CI succeeds. This is weird because the same import exists in the public folder and causes zero problems.

Do you have any idea why it fails in the server folder? It is just a node module.

@mistic
Copy link
Member

mistic commented Aug 31, 2021

@stratoula could you check if my draft PR will make your CI PR to pass? #110626

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review September 1, 2021 08:41
@stratoula stratoula requested review from a team as code owners September 1, 2021 08:41
@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 labels Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@spalger
Copy link
Contributor

spalger commented Sep 2, 2021

@elasticmachine merge upstream

(merging upstream to make sure this PR is compliant with the ESLint changes we made yesterday)

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Sep 3, 2021
@elastic elastic deleted a comment from kibanamachine Sep 3, 2021
@elastic elastic deleted a comment from kibanamachine Sep 3, 2021
mbondyra
mbondyra approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ff by just clicking through things. Everything works fine. LGTM 👌🏼

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 33c124b into elastic:master Sep 3, 2021
@stratoula stratoula mentioned this pull request Sep 3, 2021
Merged
stratoula added a commit to stratoula/kibana that referenced this pull request Sep 3, 2021
@stratoula
Move to vis_types folder part 2 (elastic#110574)
ae44d35 
* Move to vis_types folder part 2

* fix jest tests

* do some tests

* revert

* Test Tiago's fix

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	.github/CODEOWNERS
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into vis/migrate-r…
7fe9e60 
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (65 commits)
  Move to vis_types folder part 2 (elastic#110574)
  [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023)
  [Discover] Remove export* syntax (elastic#110934)
  [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365)
  [Security Solution][Detection Rules] Changes 'activated' text on rule details page  (elastic#111044)
  [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300)
  [package testing] Update logging and pid configuration (elastic#111059)
  [Dashboard] Read App State from URL on Soft Refresh (elastic#109354)
  Add correct roles to test user for functional tests in dashboard (elastic#110880)
  [DOCS] Adds Lens Inspector and minor edits (elastic#109736)
  [DOCS] Updates Spaces page (elastic#111005)
  normalize initialNamespaces (elastic#110936)
  [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740)
  [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253)
  skip flaky suites: elastic#111001, elastic#111022
  [Security Solution][RAC] - Update reason field text (elastic#110308)
  [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913)
  [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971)
  [DOCS] Updates Discover docs (elastic#110346)
  [RAC] Persistent timeline fields fix (elastic#110685)
  ...
stratoula added a commit that referenced this pull request Sep 3, 2021
@stratoula
Move to vis_types folder part 2 (#110574) (#111092)
c13f6ad 
* Move to vis_types folder part 2

* fix jest tests

* do some tests

* revert

* Test Tiago's fix

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	.github/CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stratoula @mistic @elasticmachine @spalger @kibanamachine @MichaelMarcialis @mbondyra