Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Fixed loading layout #110461

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[ILM] Fixed loading layout #110461

merged 1 commit into from
Aug 30, 2021

Conversation

yuliacech
Copy link
Contributor

Fixes #109984

Summary

This PR fixes a visual bug introduced in PR#106734 as suggested by @alisonelizabeth in PR#109726.

Screencasts

Before

Screen.Recording.2021-08-23.at.18.12.07.mov

After

Screen.Recording.2021-08-30.at.13.38.10.mov

@yuliacech yuliacech added bug Fixes for quality problems that affect the customer experience Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 labels Aug 30, 2021
@yuliacech yuliacech requested a review from a team as a code owner August 30, 2021 11:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Did not test locally. Thanks for fixing this!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 245.8KB 245.9KB +79.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 48.3KB 48.6KB +230.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech
Copy link
Contributor Author

Thank you for the review, @alisonelizabeth! But most importantly for flagging this bug and finding a fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ILM] Layout issues with loading/empty states
4 participants