Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View request flyout #127156

Merged
merged 20 commits into from
Mar 22, 2022
Merged

View request flyout #127156

merged 20 commits into from
Mar 22, 2022

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Mar 8, 2022

Fixes: #110926 and https://github.com/elastic/kibana-team/issues/435

Summary

This PR adds a generic view request flyout to es_ui_shared that can be used anywhere we want to expose an ES API requests to the user. Allowing the user to also copy the request to their clipboard and to view the request in Console.

I've also implemented the modal in the request preview in the ingest pipelines edit screen.

Note: There are more of these modals throughout our apps (CCR, remote clusters, ILM, watcher and rollups) I decided to implement it only for Ingest Pipelines to keep the PR more concise and will create another small PR after for patching that up.

How to test

  1. Start elasticsearch and kibana
  2. Navigate to Stack Management -> Ingest pipelines
  3. Edit an existing pipeline or create a new one
  4. Verify that the show request button works and flyout opens
  5. Verify that the copy to clipboard works and that the show in console works also

Screenshots

before/after

// Before
Screenshot 2022-03-10 at 15 24 19

// After
Screenshot 2022-03-10 at 15 22 09

@sabarasaba sabarasaba self-assigned this Mar 8, 2022
@sabarasaba sabarasaba force-pushed the view_request_flyout branch from 82ede31 to aa7ff5c Compare March 10, 2022 13:27
@sabarasaba sabarasaba added >enhancement Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.2.0 labels Mar 10, 2022
@sabarasaba sabarasaba marked this pull request as ready for review March 11, 2022 13:34
@sabarasaba sabarasaba requested a review from a team as a code owner March 11, 2022 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the request flyout, @sabarasaba! Looking forward to reuse it in other apps as well 👍
Left you a couple of comments in the code, but it looks really great already.

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba requested a review from yuliacech March 18, 2022 07:36
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @sabarasaba!
Latest changes LGTM, didn't re-test locally

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esUiShared 158 161 +3
ingestPipelines 458 457 -1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
esUiShared 106 108 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 452.0KB 451.4KB -607.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 122.5KB 129.2KB +6.7KB
ingestPipelines 13.3KB 13.4KB +55.0B
total +6.8KB
Unknown metric groups

API count

id before after diff
esUiShared 110 112 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit e9d0769 into elastic:main Mar 22, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127156 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2022
@sabarasaba sabarasaba added the backport:skip This commit does not require backporting label Mar 24, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2022
@cjcenizal cjcenizal added the Feature:Console Dev Tools Console Feature label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generalized "View API request" flyout to es_ui_shared
6 participants