-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View request flyout #127156
View request flyout #127156
Conversation
82ede31
to
aa7ff5c
Compare
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
src/plugins/es_ui_shared/public/components/view_api_request_flyout/view_api_request_flyout.tsx
Outdated
Show resolved
Hide resolved
src/plugins/es_ui_shared/public/components/view_api_request_flyout/view_api_request_flyout.tsx
Outdated
Show resolved
Hide resolved
src/plugins/es_ui_shared/public/components/view_api_request_flyout/view_api_request_flyout.tsx
Outdated
Show resolved
Hide resolved
src/plugins/es_ui_shared/public/components/view_api_request_flyout/view_api_request_flyout.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with the request flyout, @sabarasaba! Looking forward to reuse it in other apps as well 👍
Left you a couple of comments in the code, but it looks really great already.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @sabarasaba!
Latest changes LGTM, didn't re-test locally
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Fixes: #110926 and https://github.com/elastic/kibana-team/issues/435
Summary
This PR adds a generic view request flyout to es_ui_shared that can be used anywhere we want to expose an ES API requests to the user. Allowing the user to also copy the request to their clipboard and to view the request in Console.
I've also implemented the modal in the request preview in the ingest pipelines edit screen.
Note: There are more of these modals throughout our apps (CCR, remote clusters, ILM, watcher and rollups) I decided to implement it only for
Ingest Pipelines
to keep the PR more concise and will create another small PR after for patching that up.How to test
Stack Management
->Ingest pipelines
Screenshots
before/after
// Before
// After