Do not use outdated request package in tests.
#109225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
v8.0.0
release_note:skip
azasypkin
force-pushed
the
issue-xxx-ditch-request-from-tests
branch
from
27226a2 to
1e89503
Compare
azasypkin
commented
Aug 23, 2021
| @@ -103,7 +103,7 @@ interface Storage { | |||
| } | |||
|
|
|||
| function retrieveSessionCookie(cookies: string) { | |||
| const sessionCookie = request.cookie(cookies); | |||
| const sessionCookie = parseCookie(cookies); | |||
There was a problem hiding this comment.
note: unfortunately couldn't test this change as the entire test suite is skipped for the last 5 months 😢
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
Aug 24, 2021
jportner
approved these changes
Aug 24, 2021
| // Do not assert on the `authentication_realm`, as the value differes for on-prem vs cloud | ||
| // Do not assert on the `authentication_realm`, as the value differs for on-prem vs cloud |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
azasypkin
added
auto-backport
💔 Backport failed
To backport manually run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we switch to a well-maintained
tough-cookiepackage to parseset-cookieHTTP headers in our tests instead of relying on the deprecated and unmaintainedrequestpackage. Unlikerequestwe maketough-cookiea dev-only dependency.Related to: #109202