Migrate away from request package in kibana_usage_collection plugin

[azasypkin]

The request package has been deprecated long ago: request/request#3142. The last release was in 2018 (!!!) and new ones aren't planned (including security patches). We should do our best to get rid of this package completely as soon as we can.

It seems CloudService is the only non-test consumer of this package.

We're (Platform Security) are going to update all tests that still rely on this package, but we'll need your help to migrate CloudService.

Thanks!

[elasticmachine]

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

[mshustov]

@azasypkin As I understand there is no deadline? Can it wait until after v8.0 release?

[azasypkin]

@azasypkin As I understand there is no deadline? Can it wait until after v8.0 release?

Yep, there is no deadline, v8.0 sounds reasonable to me. But as usual the sooner the better and we'll need to backport this update to 7.x anyway.

[azasypkin]

Sent PR that removes request package from all tests in Kibana: #109225

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[mshustov]

Sent PR that removes request package from all tests in Kibana

Considering kibana_usage_collection is the last consumer of the package, we should remove the library from the dependency list in package.json

[azasypkin]

Considering kibana_usage_collection is the last consumer of the package, we should remove the library from the dependency list in package.json

Yep, that was the goal! 🙂

[lukeelmers]

If we are already doing this cleanup, we should look at #96711 and evaluate whether it is worth the effort to tackle both issues at the same time. (Removing request was already one of the items outlined in that issue).

IMO this issue takes priority, but if some of the other tasks can be done without too much effort, it would be an easy win.

[mshustov]

@lukeelmers added both to Next column to take in work in the next sprint