-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC][Observability] temporarily hide severity column #109004
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column is gone as expected 👍 But I suspect the fly-out still shows it, right?
Yep true, I forgot to remove it from the flyout. I am currently working on indexing the severity column in another draft PR #109068 and soon it should end up on master. Shall we merge this one as it is at the moment? |
As discussed I will remove severity from flyout and polish up #109068 |
x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mgiota |
* [RAC][Observability] temporarily hide severity column * remove severity from flyout & rename Trigerred to last updated Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
) * [RAC][Observability] temporarily hide severity column * remove severity from flyout & rename Trigerred to last updated Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: mgiota <[email protected]>
* [RAC][Observability] temporarily hide severity column * remove severity from flyout & rename Trigerred to last updated Co-authored-by: Kibana Machine <[email protected]>
) * [RAC][Observability] temporarily hide severity column * remove severity from flyout & rename Trigerred to last updated Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
In this PR we temporarily remove the Severity column.
Fixes #108162
Fixes #109076.
📝 Notes
There are ongoing discussions regarding the severity field name we should index
ALERT_SEVERITY_LEVEL
vsALERT_SEVERITY
. Suggestion is to useALERT_SEVERITY
. There is already work in progress, which will take care of renaming the fields.