Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][Observability] temporarily hide severity column #109004

Merged
merged 6 commits into from
Aug 18, 2021

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Aug 17, 2021

In this PR we temporarily remove the Severity column.

Fixes #108162
Fixes #109076.

📝 Notes

There are ongoing discussions regarding the severity field name we should index ALERT_SEVERITY_LEVEL vs ALERT_SEVERITY. Suggestion is to use ALERT_SEVERITY. There is already work in progress, which will take care of renaming the fields.

@mgiota mgiota added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete v7.15.0 labels Aug 17, 2021
@mgiota mgiota self-assigned this Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@mgiota
Copy link
Contributor Author

mgiota commented Aug 18, 2021

@elasticmachine merge upstream

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column is gone as expected 👍 But I suspect the fly-out still shows it, right?

@mgiota
Copy link
Contributor Author

mgiota commented Aug 18, 2021

The column is gone as expected 👍 But I suspect the fly-out still shows it, right?

Yep true, I forgot to remove it from the flyout. I am currently working on indexing the severity column in another draft PR #109068 and soon it should end up on master. Shall we merge this one as it is at the moment?

@mgiota
Copy link
Contributor Author

mgiota commented Aug 18, 2021

As discussed I will remove severity from flyout and polish up #109068

@mgiota mgiota enabled auto-merge (squash) August 18, 2021 12:08
@mgiota
Copy link
Contributor Author

mgiota commented Aug 18, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 492.1KB 490.9KB -1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

@mgiota mgiota merged commit ed78d4b into elastic:master Aug 18, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 18, 2021
* [RAC][Observability] temporarily hide severity column

* remove severity from flyout & rename Trigerred to last updated

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 18, 2021
)

* [RAC][Observability] temporarily hide severity column

* remove severity from flyout & rename Trigerred to last updated

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: mgiota <[email protected]>
mgiota added a commit to mgiota/kibana that referenced this pull request Aug 19, 2021
* [RAC][Observability] temporarily hide severity column

* remove severity from flyout & rename Trigerred to last updated

Co-authored-by: Kibana Machine <[email protected]>
mgiota added a commit that referenced this pull request Aug 19, 2021
)

* [RAC][Observability] temporarily hide severity column

* remove severity from flyout & rename Trigerred to last updated

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@mgiota mgiota deleted the hide_severity_column branch January 4, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAC][Observability] Rename Last triggered label in the alerts flyout [Observability RAC] Severity column
4 participants