Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability RAC] Severity column #108162

Closed
mgiota opened this issue Aug 11, 2021 · 4 comments · Fixed by #109004
Closed

[Observability RAC] Severity column #108162

mgiota opened this issue Aug 11, 2021 · 4 comments · Fixed by #109004
Assignees
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Aug 11, 2021

📝 Summary

As part of this #107029 the severity of the alerts is left empty if it's unknown. We should display a dash instead. In case it is a warning we should display warning.

✔️ Acceptance criteria

  • diplay warning if it is a warning
  • when the severity is not specified in the document, display a dash instead of it being empty
  • for critical color badges we should use danger
  • for warning color badges we should use warning

Note:

  • let's look into whether severity can be indexed for more rule types

@katrin-freihofner Did I specify correctly the color names/classes?

UPDATE

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 11, 2021
@mgiota mgiota added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 11, 2021
@mgiota mgiota added auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v8.0.0 Theme: rac label obsolete labels Aug 11, 2021
@katrin-freihofner
Copy link
Contributor

@mgiota yes, it's a EuiBadge in color danger or warning as described - I will update the description.

@jasonrhodes
Copy link
Member

We should show the empty cell if the value is not indexed, but we should consider making more of our rule types specify a severity explicitly so that we have less alerts with this "unknown" value.

@jasonrhodes
Copy link
Member

jasonrhodes commented Aug 13, 2021

Update: we may want to just remove this column for now if we don't have time to make sure the rule types are indexing the severity value. Ping @katrin-freihofner / @mdefazio just a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants