Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index pattern management] Restore cross cluster search functionality #108756

Merged
merged 3 commits into from
Aug 17, 2021
Merged

[index pattern management] Restore cross cluster search functionality #108756

merged 3 commits into from
Aug 17, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Aug 16, 2021 •
edited
Loading

Summary

This restores cross cluster search functionality to index pattern creation which is necessary when remote clusters are on early 7.x or 6.x versions.

The code was restored with slight modifications from 7.14.

Closes: #108304

@mattkime mattkime requested a review from a team as a code owner August 16, 2021 18:12
@mattkime mattkime added 8.0.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Aug 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime added v7.15.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Aug 16, 2021
@mattkime mattkime requested a review from Dosant August 16, 2021 18:13
@mattkime mattkime changed the title restore cross cluster search functionality [index pattern management] Restore cross cluster search functionality Aug 16, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternEditor 169.3KB 171.7KB +2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 791.0KB 791.0KB +2.0B
indexPatternEditor 21.0KB 21.1KB +189.0B
total +191.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukasolson lukasolson added v8.0.0 and removed 8.0.0 labels Aug 17, 2021
@Dosant Dosant mentioned this pull request Aug 17, 2021
Closed
Dosant
Dosant approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, mostly copied from 7.14 branch

This is how I tested:

  1. Took a 7.x branch pointed to 6.8 cluster, reproduced the bug
  2. Applied this pr changs to 7.x branch, checked that can find remote index pattern from 6.8 cluster

@mattkime mattkime merged commit 5b5e152 into elastic:master Aug 17, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 108756

@mattkime mattkime mentioned this pull request Aug 17, 2021
Merged
mattkime added a commit to mattkime/kibana that referenced this pull request Aug 17, 2021
@mattkime
[index pattern management] Restore cross cluster search functionality (…
0bc13e2 
…elastic#108756)

* restore cross cluster search functionality
# Conflicts:
#	src/plugins/index_pattern_editor/public/lib/get_indices.test.ts
mattkime added a commit that referenced this pull request Aug 17, 2021
@mattkime
[index pattern management] Restore cross cluster search functionality (…
743d720 
…#108756) (#108977)

* restore cross cluster search functionality
# Conflicts:
#	src/plugins/index_pattern_editor/public/lib/get_indices.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross Cluster Search from 7.x to 6.8 can't create index pattern
5 participants
@mattkime @elasticmachine @kibanamachine @Dosant @lukasolson