Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Patterns] Fix empty prompts remote cluster check #108930

Closed
Dosant opened this issue Aug 17, 2021 · 1 comment · Fixed by #110054
Closed

[Index Patterns] Fix empty prompts remote cluster check #108930

Dosant opened this issue Aug 17, 2021 · 1 comment · Fixed by #110054
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@Dosant
Copy link
Contributor

Dosant commented Aug 17, 2021 •
edited
Loading

This wouldn't be a regression from this pr, but looks like this was never called, hence empty prompt never uses remove cluster logic
I think the intention was to use useMemo or useEffect instead

Originally posted by @Dosant in #108756 (comment)
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:AppServices labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant added Feature:Data Views Data Views code and UI - index patterns before 8.0 and removed Feature:Index Management Index and index templates UI labels Aug 17, 2021
@Dosant Dosant mentioned this issue Aug 17, 2021
Merged
@Dosant Dosant mentioned this issue Aug 25, 2021
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataViews] Fix checking remote clusters in empty state Dosant/kibana
2 participants
@Dosant @elasticmachine