[Uptime] migrate legacy alert apis

[dominiqueclarke]

Summary

Migrates away to the updated Rule APIs

These APIs are responsible for 4 functions in Uptime, all of which should be tested for regression.

1. Creating and delete the default monitor status rule in the status alert toggle

2. Display currently enabled rules

3. Displaying connector options

4. Displaying available configured connectors

Fixes #94089
Fixes #95839

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[dominiqueclarke]

@justinkambic Any better ideas for how to handle this?

[YulNaumenko]

LGTM!

[dominiqueclarke]

@elasticmachine merge upstream

[justinkambic]

Looking pretty good. Not approving yet as I've only done code review so far; I will post another review with my smoke-test results.

[justinkambic]

How about we do this instead, we can make the return object a little cleaner and it avoids the eslint messiness in exchange for some added verbiage in the parameter destructuring.

Suggested change

	/* eslint-disable @typescript-eslint/naming-convention */
	return response.map(
	({ connector_type_id, referenced_by_count, is_preconfigured, is_missing_secrets, ...res }) => ({
	...res,
	actionTypeId: connector_type_id,
	referencedByCount: referenced_by_count,
	isPreconfigured: is_preconfigured,
	isMissingSecrets: is_missing_secrets,
	})
	);
	/* eslint-enable @typescript-eslint/naming-convention */
	return response.map(
	({
	connector_type_id: actionTypeId,
	referenced_by_count: referencedByCount,
	is_preconfigured: isPreconfigured,
	is_missing_secrets: isMissingSecrets,
	...res
	}) => ({
	...res,
	actionTypeId,
	referencedByCount,
	isPreconfigured,
	isMissingSecrets,
	})
	);

[justinkambic]

Same recommendation here; this allows us to remove the eslint-disable.

Suggested change

	/* eslint-disable @typescript-eslint/naming-convention */
	return response.map<ActionType>(
	({
	enabled_in_config,
	enabled_in_license,
	minimum_license_required,
	...res
	}: AsApiContract<ActionType>) => ({
	...res,
	enabledInConfig: enabled_in_config,
	enabledInLicense: enabled_in_license,
	minimumLicenseRequired: minimum_license_required,
	})
	);
	/* eslint-enable @typescript-eslint/naming-convention */
	return response.map<ActionType>(
	({
	enabled_in_config: enabledInConfig,
	enabled_in_license: enabledInLicense,
	minimum_license_required: minimumLicenseRequired,
	...res
	}: AsApiContract<ActionType>) => ({
	...res,
	enabledInConfig,
	enabledInLicense,
	minimumLicenseRequired,
	})
	);

[justinkambic]

Smoke test results

Connectors are displayed

Defined connectors displayed:

Create simple monitor alert:

Enabled rules:

Everything's looking good on my side.

[dominiqueclarke]

@elasticmachine merge upstream

[dominiqueclarke]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 380e89b
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
uptime	954.5KB	955.0KB	+534.0B

Unknown metric groups

API count

id	before	after	diff
triggersActionsUi	237	238	+1

API count missing comments

id	before	after	diff
triggersActionsUi	228	229	+1

History

• 💚 Build #145209 succeeded 8a5c66b
• 💚 Build #144944 succeeded 9c41e38
• 💚 Build #144390 succeeded eb4ecb1
• 💚 Build #143545 succeeded 4ba8ab9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[justinkambic]

LGTM

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.