Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Uptime to new Connectors APIs in place of deprecated APIs #94089

Closed
gmmorris opened this issue Mar 9, 2021 · 3 comments · Fixed by #107863
Closed

Migrate Uptime to new Connectors APIs in place of deprecated APIs #94089

gmmorris opened this issue Mar 9, 2021 · 3 comments · Fixed by #107863
Assignees
Labels
blocker Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.15.0 v8.0.0

Comments

@gmmorris
Copy link
Contributor

gmmorris commented Mar 9, 2021

Following the work on #90376 we have deprecated the Connector REST APIs that refer to Connectors as Actions.

The new APIs are documented here: https://www.elastic.co/guide/en/kibana/master/actions-and-connectors-api.html

As of 8.0 the deprecated APIs will no longer be available, so this issue is to remove the usage of these APIs from Uptime.

Note that the changes cover both the routes and the parameters (to correctly follow the styleguide).

@gmmorris gmmorris added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 labels Mar 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@mikecote
Copy link
Contributor

We will need this done, merged and backported before 7.15.0 feature freeze so we can remove the code in the 7.16/8.0 release cycle.

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Jul 26, 2021

We are using 2 soon to be deprecated apis. The routes are defined in x-pack/plugins/uptime/common/constants/rest_api.ts and used in x-pack/plugins/uptime/public/state/api/alerts.ts.

GET /api/actions/list_action_types
GET /api/actions

We'll need to update based on the new routes defined in #90376.

GET /api/actions/list_action_types => /api/actions/connector_types
GET /api/actions => /api/actions/connectors

@andrewvc andrewvc assigned andrewvc and unassigned dominiqueclarke Aug 20, 2021
@andrewvc andrewvc added the test-plan-ok issue has passed test plan label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants