-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Cleanup bar value labels configuration #106231
Conversation
I prefer the first one (the current state of the PR). I am not very fond of the outline, and taken under consideration the users' feedback on that I would like to go with the |
1st and 3rd options look good to me. |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* 🐛 Rework value labels config * 📷 Update snapshots
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* 🐛 Rework value labels config * 📷 Update snapshots Co-authored-by: Marco Liberati <[email protected]>
* 🐛 Rework value labels config * 📷 Update snapshots
Summary
Made this PR as playground for value labels configuration.
Fixes #101573
Winner
Here's the result of the current state of this PR, with the following configuration:
outline: off, textContrast: on, invertText: off
(3 votes)
Alternatives considered
Here's a rendering with the current outline enabled:
outline: on, textContrast: on, invertText: off
(0 votes)
And at last a rendering with a reduced outline:
outline: 1px, textContrast: on, invertText: off
(1 vote)
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers