Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Remove value labels flag for vertical displacement #105231

Closed

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jul 12, 2021

Summary

This PR removes the value label vertical displacement as mentioned in #101573 for Lens bar charts.

Before:

Screenshot 2021-07-12 at 16 53 56

After:

Screenshot 2021-07-12 at 16 53 00

If you are wondering why this feature was enabled to begin with, the reason was that testing with very crowded bar charts the flag was preventing this from happening:

Screenshot 2021-07-12 at 16 54 48

With the flag enabled:

Screenshot 2021-07-12 at 16 54 15

Hopefully this edge case will be taken care from the charts library itself with the new geometry clipped flag: elastic/elastic-charts#1233

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dej611 dej611 requested a review from markov00 July 12, 2021 15:00
@dej611
Copy link
Contributor Author

dej611 commented Jul 19, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.
The current feature doesn't improve much the readability with smaller bars and can create more problems than benefits.
IMHO is not even a breaking change

@stratoula
Copy link
Contributor

I agree with @markov00 👍

@dej611
Copy link
Contributor Author

dej611 commented Jul 20, 2021

closing this in favour of #106231 which has more options

@dej611 dej611 closed this Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants