Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add telemetry to track usage of the agent config to fleet synchronisation feature #105297

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #99249

The page view event is tracked automatically now, following this pattern: pageview__{{path}}, where path is the one defined in the route configuration.

The downside of this, is that we'll lose track of historical information, since it didn't use to use the path as the key but instead a string representing each page.

APM UI:
Screen Shot 2021-07-12 at 14 14 19
Screen Shot 2021-07-12 at 14 14 34
Screen Shot 2021-07-12 at 14 14 45

APM UI switch to data stream:
Screen Shot 2021-07-12 at 15 08 51

APM server sync agent config:
Screen Shot 2021-07-12 at 14 57 11

@cauemarcondes cauemarcondes added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Jul 12, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 12, 2021 19:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes changed the title Apm telemtry UI [APM] Add telemetry to track usage of the agent config to fleet synchronisation feature Jul 12, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1566 1567 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
apm 38 39 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -796.0B
Unknown metric groups

API count

id before after diff
apm 38 39 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 13, 2021
@cauemarcondes cauemarcondes merged commit ee8c9be into elastic:master Jul 13, 2021
@cauemarcondes cauemarcondes deleted the apm-telemtry-ui branch July 13, 2021 16:33
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2021
…ronisation feature (elastic#105297)

* removing telemetry hook from pages

* adding telemetry to schema and agent config
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.14 Commit could not be cherrypicked due to conflicts
7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 105297

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jul 13, 2021
…ronisation feature (elastic#105297)

* removing telemetry hook from pages

* adding telemetry to schema and agent config
# Conflicts:
#	x-pack/plugins/apm/server/routes/register_routes/index.ts
kibanamachine added a commit that referenced this pull request Jul 13, 2021
…ronisation feature (#105297) (#105462)

* removing telemetry hook from pages

* adding telemetry to schema and agent config

Co-authored-by: Cauê Marcondes <[email protected]>
cauemarcondes added a commit that referenced this pull request Jul 13, 2021
…t synchronisation feature (#105297) (#105468)

* [APM] Add telemetry to track usage of the agent config to fleet synchronisation feature (#105297)

* removing telemetry hook from pages

* adding telemetry to schema and agent config
# Conflicts:
#	x-pack/plugins/apm/server/routes/register_routes/index.ts

* fixing merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Add telemetry to track usage of the agent config to fleet synchronisation feature
4 participants