Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Page tracking only works on full page reload #107728

Closed
dgieselaar opened this issue Aug 5, 2021 · 3 comments · Fixed by #107741
Closed

[APM] Page tracking only works on full page reload #107728

dgieselaar opened this issue Aug 5, 2021 · 3 comments · Fixed by #107741
Assignees
@cauemarcondes
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@dgieselaar
Copy link
Member

In #105297, page tracking was moved to a single component, but as effectDependencies are never defined, the report function is only called when the component mounts, which effectively means only on a full page reload (or when navigating with the side bar, which is when the entire APM app mounts and unmounts).
@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Aug 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv mentioned this issue Aug 5, 2021
Closed
@sorenlouv
Copy link
Member

Created a follow-up to this: #107734

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Aug 5, 2021
@dgieselaar
[APM] Invalidate trackPageview no route change
f936a7b 
Closes elastic#107728.
@dgieselaar dgieselaar mentioned this issue Aug 5, 2021
Merged
@zube zube bot assigned dgieselaar Aug 5, 2021
dgieselaar added a commit that referenced this issue Aug 6, 2021
@dgieselaar
[APM] Invalidate trackPageview on route change (#107741)
2407080 
Closes #107728.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 6, 2021
@dgieselaar @kibanamachine
[APM] Invalidate trackPageview on route change (elastic#107741)
ab9599b 
Closes elastic#107728.
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Aug 6, 2021
@dgieselaar
[APM] Invalidate trackPageview on route change (elastic#107741)
e34f988 
Closes elastic#107728.
# Conflicts:
#	x-pack/plugins/apm/public/components/routing/track_pageview.tsx
kibanamachine added a commit that referenced this issue Aug 6, 2021
@kibanamachine @dgieselaar
[APM] Invalidate trackPageview on route change (#107741) (#107828)
44c1d99 
Closes #107728.

Co-authored-by: Dario Gieselaar <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this issue Aug 8, 2021
@dgieselaar @vadimkibana
[APM] Invalidate trackPageview on route change (elastic#107741)
28b5fe6 
Closes elastic#107728.
@cauemarcondes cauemarcondes self-assigned this Aug 23, 2021
@cauemarcondes
Copy link
Contributor

Tests okay.

@cauemarcondes cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Invalidate trackPageview on route change dgieselaar/kibana
4 participants
@sorenlouv @dgieselaar @elasticmachine @cauemarcondes