Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add “Analyze Data” button #103485

Merged
merged 9 commits into from
Jun 30, 2021
Merged

[APM] Add “Analyze Data” button #103485

merged 9 commits into from
Jun 30, 2021

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Jun 28, 2021 •
edited
Loading

Closes #100759

image

@sorenlouv sorenlouv requested a review from a team as a code owner June 28, 2021 14:02
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

formgeist
formgeist reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the icon wasn't exactly the one used in UX and Uptime 👀

x-pack/plugins/apm/public/components/routing/templates/apm_service_template.tsx Outdated Show resolved Hide resolved
@sorenlouv sorenlouv requested review from a team as code owners June 29, 2021 12:03
@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 29, 2021
TinaHeiligers
TinaHeiligers approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

@sorenlouv sorenlouv force-pushed the add-analyze-button branch from 25c6384 to c9ee119 Compare June 29, 2021 23:21
@sorenlouv sorenlouv enabled auto-merge (squash) June 29, 2021 23:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +2.9KB

History

  • 💚 Build #135065 succeeded 25c6384604a778169a7ef7fb888ba89e13ef79ee
  • 💚 Build #135048 succeeded b6049c58594949067937bc4c86159bdaabde11ad
  • 💔 Build #135042 failed e277a235ace0bcfc3891c5271dde3666c4f0d265
  • 💔 Build #134994 failed ec2029f17063f0001e20a44de01a7021ebcbf290
  • 💔 Build #134644 failed 9377a1813680ae04d117aee77a0f8ee104c2935c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv disabled auto-merge June 30, 2021 07:14
@sorenlouv sorenlouv merged commit 4aca0b7 into elastic:master Jun 30, 2021
@sorenlouv sorenlouv deleted the add-analyze-button branch June 30, 2021 08:20
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2021
@sorenlouv @shahzad31 @kibanamachine
[APM] Add “Analyze Data” button (elastic#103485)
9f4dea2 
Co-authored-by: Shahzad <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Jun 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 30, 2021
@kibanamachine @sorenlouv @shahzad31
[APM] Add “Analyze Data” button (#103485) (#103843)
024d4a5 
Co-authored-by: Shahzad <[email protected]>

Co-authored-by: Søren Louv-Jansen <[email protected]>
Co-authored-by: Shahzad <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
a29672d 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
@gbamparop gbamparop mentioned this pull request Jul 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryce-b bryce-b bryce-b left review comments

@formgeist formgeist formgeist left review comments

@shahzad31 shahzad31 shahzad31 left review comments

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone