Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Metric count is depicted as - instead of 0 #103717

Merged
merged 4 commits into from
Jun 30, 2021
Merged

[TSVB] Metric count is depicted as - instead of 0 #103717

merged 4 commits into from
Jun 30, 2021

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Jun 29, 2021 •
edited
Loading

Closes #102179

Summary

Made TSVB display zero instead of a dash when there's no data for Count, Cardinality and Sum aggregations.

image

image

image

Checklist

For maintainers

@DianaDerevyankina DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 29, 2021
@DianaDerevyankina DianaDerevyankina self-assigned this Jun 29, 2021
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

17 similar comments
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

@DianaDerevyankina
Rename extractData to mapEmptyToZero and remove unnecessary intervalS…
9f90cc2 
…tring undefined assignment in get_bucket_size.js
@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

stratoula
stratoula approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, it seems fine to me 🙂
If @alexwizp is also ok, let's 🚢 it

alexwizp
alexwizp approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexwizp alexwizp marked this pull request as ready for review June 30, 2021 11:52
@alexwizp alexwizp requested a review from a team June 30, 2021 11:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 30, 2021
VladLasitsa
VladLasitsa approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@alexwizp alexwizp enabled auto-merge (squash) June 30, 2021 12:39
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@alexwizp alexwizp merged commit 9f82e5e into elastic:master Jun 30, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 30, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2021
@DianaDerevyankina @kibanamachine
[TSVB] Metric count is depicted as - instead of 0 (elastic#103717)
a471a56 
* [TSVB] Metric count is depicted as - instead of 0

* Rename extractData to mapEmptyToZero and remove unnecessary intervalString undefined assignment in get_bucket_size.js

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/ilm…
3797167 
…-policy-2

* 'master' of github.com:elastic/kibana:
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)

# Conflicts:
#	x-pack/plugins/reporting/server/lib/store/store.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
a29672d 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
kibanamachine added a commit that referenced this pull request Jun 30, 2021
@kibanamachine @DianaDerevyankina
[TSVB] Metric count is depicted as - instead of 0 (#103717) (#103875)
e467354 
* [TSVB] Metric count is depicted as - instead of 0

* Rename extractData to mapEmptyToZero and remove unnecessary intervalString undefined assignment in get_bucket_size.js

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Diana Derevyankina <[email protected]>
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jul 7, 2021
@DianaDerevyankina @kibanamachine @stratoula
[TSVB] Metric count is depicted as - instead of 0 (elastic#103717)
a7426a4 
* [TSVB] Metric count is depicted as - instead of 0

* Rename extractData to mapEmptyToZero and remove unnecessary intervalString undefined assignment in get_bucket_size.js

Co-authored-by: Kibana Machine <[email protected]>
@stratoula stratoula mentioned this pull request Jul 7, 2021
Merged
stratoula added a commit that referenced this pull request Jul 7, 2021
@stratoula @DianaDerevyankina @kibanamachine
[TSVB] Metric count is depicted as - instead of 0 (#103717) (#104634)
cf5a9f0 
* [TSVB] Metric count is depicted as - instead of 0

* Rename extractData to mapEmptyToZero and remove unnecessary intervalString undefined assignment in get_bucket_size.js

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Diana Derevyankina <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@spalger spalger added the v7.15.0 label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Metric count is depicted as - instead of 0
7 participants
@DianaDerevyankina @kibanamachine @elasticmachine @VladLasitsa @stratoula @alexwizp @spalger