Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] rename beta badge to experimental #101884

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[Lens] rename beta badge to experimental #101884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc9c7cb
rename beta badge
flash1293 Jun 10, 2021
4100df1
Merge branch 'master' into lens/heatmap-experimental
kibanamachine Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/chart_switch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export const ChartSwitch = memo(function ChartSwitch(props: Props) {
<EuiIcon className="lnsChartSwitch__chartIcon" type={v.icon || 'empty'} />
),
append:
v.selection.dataLoss !== 'nothing' || v.showBetaBadge ? (
v.selection.dataLoss !== 'nothing' || v.showExperimentalBadge ? (
<EuiFlexGroup
gutterSize="xs"
responsive={false}
Expand Down Expand Up @@ -325,12 +325,12 @@ export const ChartSwitch = memo(function ChartSwitch(props: Props) {
/>
</EuiFlexItem>
) : null}
{v.showBetaBadge ? (
{v.showExperimentalBadge ? (
<EuiFlexItem grow={false}>
<EuiBadge color="hollow">
<FormattedMessage
id="xpack.lens.chartSwitch.betaLabel"
defaultMessage="Beta"
id="xpack.lens.chartSwitch.experimentalLabel"
defaultMessage="Experimental"
/>
</EuiBadge>
</EuiFlexItem>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/lens/public/heatmap_visualization/visualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const getHeatmapVisualization = ({
defaultMessage: 'Heatmap',
}),
groupLabel: groupLabelForBar,
showBetaBadge: true,
showExperimentalBadge: true,
},
],

Expand Down
7 changes: 5 additions & 2 deletions x-pack/plugins/lens/public/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export interface EditorFrameProps {
initialContext?: VisualizeFieldContext;
showNoDataPopover: () => void;
}

export interface EditorFrameInstance {
EditorFrameContainer: (props: EditorFrameProps) => React.ReactElement;
}
Expand Down Expand Up @@ -570,9 +571,9 @@ export interface VisualizationType {
*/
sortPriority?: number;
/**
* Indicates if visualization is in the beta stage.
* Indicates if visualization is in the experimental stage.
*/
showBetaBadge?: boolean;
showExperimentalBadge?: boolean;
}

export interface Visualization<T = unknown> {
Expand Down Expand Up @@ -734,6 +735,7 @@ interface LensEditContextMapping {
[LENS_EDIT_RESIZE_ACTION]: LensResizeActionData;
[LENS_TOGGLE_ACTION]: LensToggleActionData;
}

type LensEditSupportedActions = keyof LensEditContextMapping;

export type LensEditPayload<T extends LensEditSupportedActions> = {
Expand All @@ -746,6 +748,7 @@ export interface LensEditEvent<T> {
name: 'edit';
data: EditPayloadContext<T>;
}

export interface LensTableRowContextMenuEvent {
name: 'tableRowContextMenuClick';
data: RowClickContext['data'];
Expand Down