Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] rename beta badge to experimental #101884

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[Lens] rename beta badge to experimental #101884

merged 2 commits into from
Jun 15, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #101815

Screenshot 2021-06-10 at 14 14 00

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 10, 2021
@flash1293 flash1293 marked this pull request as ready for review June 10, 2021 14:28
@flash1293 flash1293 requested a review from a team June 10, 2021 14:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wylieconlon
wylieconlon approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when using English, just thought to test with the en-xa test locale and saw truncation:

Screen Shot 2021-06-14 at 2 27 12 PM

@flash1293
Copy link
Contributor Author

Good point @wylieconlon - @MichaelMarcialis what do you think about giving the chart picker dropdown a bit more horizontal space to be on the safe side for more verbose languages?

@flash1293 flash1293 merged commit 0bb3b2c into elastic:master Jun 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 15, 2021
@flash1293 @kibanamachine
rename beta badge (elastic#101884)
387b906
@kibanamachine kibanamachine mentioned this pull request Jun 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 15, 2021
@kibanamachine @flash1293
rename beta badge (#101884) (#102153)
a6841da 
Co-authored-by: Joe Reuter <[email protected]>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@flash1293
rename beta badge (elastic#101884)
dd0abcf
@MichaelMarcialis
Copy link
Contributor

Good point @wylieconlon - @MichaelMarcialis what do you think about giving the chart picker dropdown a bit more horizontal space to be on the safe side for more verbose languages?

Apologies for the late reply. I'm good with increasing the chart picker width to prevent truncation in other languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] mark heatmaps "experimental" instead of "beta"
5 participants
@flash1293 @elasticmachine @kibanamachine @MichaelMarcialis @wylieconlon