-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts] migrate x-pack/test
to composite ts project
#101441
[ts] migrate x-pack/test
to composite ts project
#101441
Conversation
x-pack/test
to composite ts project
Pinging @elastic/kibana-operations (Team:Operations) |
Pinging @elastic/kibana-qa (Team:QA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces/security changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML test changes LGTM
…-test-project-ref
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
Co-authored-by: spalger <[email protected]> # Conflicts: # x-pack/test/functional/page_objects/gis_page.ts # x-pack/test/functional/page_objects/index.ts # x-pack/test/functional/page_objects/reporting_page.ts
Co-authored-by: spalger <[email protected]> # Conflicts: # x-pack/test/functional/page_objects/gis_page.ts # x-pack/test/functional/page_objects/index.ts # x-pack/test/functional/page_objects/reporting_page.ts
* master: (54 commits) Implement "select all" rules feature (elastic#100554) [ML] Remove script fields from the Anomaly detection alerting rule executor (elastic#101607) [Security solutions][Endpoint] Update event filtering texts (elastic#101563) [Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (elastic#101107) [FTR] Updates esArchive paths [FTR] Updates esArchive paths [Security Solution][Detection Engine] Adds runtime field tests (elastic#101664) Added APM PHP agent to the list of agent names (elastic#101062) [CI] Restore old version_info behavior when .git directory is present (elastic#101642) [Fleet] Add fleet server telemetry (elastic#101400) [APM] Syncs agent config settings to APM Fleet policies (elastic#100744) [esArchiver] drop support for --dir, use repo-relative paths instead (elastic#101345) Revert "[xpack/test] restore incremental: false in ts project" [Security Solution] Remove Host Isolation feature flag (elastic#101655) [xpack/test] restore incremental: false in ts project [DOCS] Adds link to video landing page (elastic#101413) [ML] Move Index Data Visualizer into separate plugin (Part 1) (elastic#100922) Improve security plugin return types (elastic#101492) [ts] migrate `x-pack/test` to composite ts project (elastic#101441) [App Search] Updated Search UI to new URL (elastic#101320) ...
Compliment to #99148
Migrates the
x-pack/test
directory to a composite TS project which can be ref'd from other composite projects. This gets us closer to having all projects in the repo be composite and required far fewer changes than the OSS tests because many of the services/pageObjects in thex-pack/test
project already return POJOs from their providers rather than returning instances of class expressions, though a few of those were in use and were extracted to sub-classes ofFtrService
. POJOs were left in place to reduce the amount of changes necessary to be reviewed.