Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added APM PHP agent to the list of agent names #101062

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

AlexanderWert
Copy link
Member

Summary

Added APM PHP agent to the list of agent names to include it into the agent telemetry collection

For maintainers

@AlexanderWert AlexanderWert added the Team:APM All issues that need APM UI Team support label Jun 1, 2021
@AlexanderWert AlexanderWert requested a review from smith June 1, 2021 14:53
@AlexanderWert AlexanderWert requested a review from a team as a code owner June 1, 2021 14:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@@ -38,6 +38,7 @@ export const AGENT_NAMES: AgentName[] = [
'python',
'ruby',
'rum-js',
'php',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: alphabetise, please 🧹

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please alphabetize as @sqren mentioned.

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 4, 2021
@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@AlexanderWert
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 6c02081 into elastic:master Jun 8, 2021
@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 8, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 8, 2021
* Added APM PHP agent to the list of agent names to include it into the agent telemetry collection

* put php label into alphabetical order

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 9, 2021
* Added APM PHP agent to the list of agent names to include it into the agent telemetry collection

* put php label into alphabetical order

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Alexander Wert <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
* master: (54 commits)
  Implement "select all" rules feature (elastic#100554)
  [ML] Remove script fields from the Anomaly detection alerting rule executor  (elastic#101607)
  [Security solutions][Endpoint] Update event filtering texts (elastic#101563)
  [Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (elastic#101107)
  [FTR] Updates esArchive paths
  [FTR] Updates esArchive paths
  [Security Solution][Detection Engine] Adds runtime field tests (elastic#101664)
  Added APM PHP agent to the list of agent names (elastic#101062)
  [CI] Restore old version_info behavior when .git directory is present (elastic#101642)
  [Fleet] Add fleet server telemetry (elastic#101400)
  [APM] Syncs agent config settings to APM Fleet policies (elastic#100744)
  [esArchiver] drop support for --dir, use repo-relative paths instead (elastic#101345)
  Revert "[xpack/test] restore incremental: false in ts project"
  [Security Solution] Remove Host Isolation feature flag (elastic#101655)
  [xpack/test] restore incremental: false in ts project
  [DOCS] Adds link to video landing page (elastic#101413)
  [ML] Move Index Data Visualizer into separate plugin (Part 1) (elastic#100922)
  Improve security plugin return types (elastic#101492)
  [ts] migrate `x-pack/test` to composite ts project (elastic#101441)
  [App Search] Updated Search UI to new URL (elastic#101320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants