Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB viz with no timefield defined #100864

Merged
merged 1 commit into from
May 28, 2021
Merged

[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB viz with no timefield defined #100864

merged 1 commit into from
May 28, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 28, 2021 •
edited
Loading

Closes: #100778

Summary

This PR related to #100778 and fix the following case #100778 (comment)

Steps to reproduce:

  1. Install flights data set

  2. Import the following SO so.ndjson.zip

  3. Open TSVB visualization which was imported in step 2

image

alexwizp
alexwizp commented May 28, 2021
View reviewed changes
src/plugins/vis_type_timeseries/common/index_patterns_utils.test.ts
@@ -90,7 +90,7 @@ describe('fetchIndexPattern', () => {
] as IndexPattern[];

const value = await fetchIndexPattern('indexTitle', indexPatternsService, {
fetchKibabaIndexForStringIndexes: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix grammar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibaba 😂

alexwizp
alexwizp commented May 28, 2021
View reviewed changes
...e_timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx
@@ -98,25 +96,6 @@ export const IndexPatternSelect = ({
});
}, [fetchedIndex]);

useEffect(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this effect was moved into parent component to reuse fetchedIndex for field selector placeholder

@alexwizp alexwizp requested a review from VladLasitsa May 28, 2021 12:18
@alexwizp alexwizp added v7.14.0 v8.0.0 Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed labels May 28, 2021
@alexwizp alexwizp self-assigned this May 28, 2021
@stratoula stratoula marked this pull request as ready for review May 28, 2021 12:40
@stratoula stratoula requested a review from a team May 28, 2021 12:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula changed the title [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB viz with no timefield defined May 28, 2021
stratoula
stratoula approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, solves the problem. I tested it locally using Chrome

VladLasitsa
VladLasitsa approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp enabled auto-merge (squash) May 28, 2021 13:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.7MB 1.7MB +548.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 8715de8 into elastic:master May 28, 2021
@kibanamachine kibanamachine mentioned this pull request May 28, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 28, 2021
@alexwizp @kibanamachine
[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864)
a191788 
Closes: elastic#100778
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.13 Commit could not be cherrypicked due to conflicts
✅ 7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 100864

@alexwizp alexwizp mentioned this pull request May 28, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request May 28, 2021
@alexwizp
[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864)
611fd67 
Closes: elastic#100778
# Conflicts:
#	src/plugins/vis_type_timeseries/public/application/components/index_pattern.js
@stratoula stratoula removed the blocker label May 28, 2021
kibanamachine added a commit that referenced this pull request May 28, 2021
@kibanamachine @alexwizp
[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (#100864) (#10…
3fe14f4 
…0883)

Closes: #100778

Co-authored-by: Alexey Antonov <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 28, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
d1de507 
* master: (77 commits)
  [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015)
  [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809)
  updating the saved objects test to include more saved object types (elastic#100828)
  [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789)
  Fixing ES archive mapping failure (elastic#100835)
  Fix bug with Observability > APM header navigation (elastic#100845)
  [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668)
  [Actions] Taking space id into account when creating email footer link (elastic#100734)
  Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823)
  [Security Solution] Improve find rule and find rule status route performance (elastic#99678)
  [DOCS] Adds video to introduction (elastic#100906)
  [Fleet] Improve combo box for fleet settings (elastic#100603)
  [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813)
  [DOCS] Adds Lens video (elastic#100898)
  [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765)
  chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810)
  [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718)
  [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864)
  [Lens] Adds dynamic table cell coloring (elastic#95217)
  [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853)
  ...
alexwizp added a commit that referenced this pull request May 31, 2021
@alexwizp
[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (#100864) (#10…
1b412c1 
…0888)

Closes: #100778
# Conflicts:
#	src/plugins/vis_type_timeseries/public/application/components/index_pattern.js
@bhavyarm bhavyarm added v7.13.2 and removed v7.13.1 labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.2 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0
6 participants
@alexwizp @elasticmachine @kibanamachine @VladLasitsa @stratoula @bhavyarm