[Actions] Taking space id into account when creating email footer link #100734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Actions
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
chrisronline
approved these changes
May 27, 2021
| actionTypeId, | ||
| actionParams, | ||
| }: InjectActionParamsOpts) { | ||
| // Inject kibanaFooterLink if action type is email. This is used by the email action type | ||
| // to inject a "View alert in Kibana" with a URL in the email's footer. | ||
| if (actionTypeId === '.email') { | ||
| const spacePrefix = spaceId.length > 0 && spaceId !== 'default' ? `/s/${spaceId}` : ''; |
There was a problem hiding this comment.
Is the spaceId.length > 0 check necessary? Is it possible to not be in a space, or in a space without a name?
There was a problem hiding this comment.
I think it's not possible? I wanted to cover all my bases am happy to remove.
There was a problem hiding this comment.
I'd defer to your judgment here, but I wasn't sure if it was possible or not
There was a problem hiding this comment.
The only thing I can think of is testing the behaviour when the spaces plugin is disabled xpack.spaces.enabled: false.
mikecote
approved these changes
May 28, 2021
There was a problem hiding this comment.
Changes LGTM! I see there were also some conversations about customers forgetting to include Space ID when using {{kibanaBaseUrl}} (#99300 (comment)), should we open a follow-up issue for that scenario?
| text: i18n.translate('xpack.alerting.injectActionParams.email.kibanaFooterLinkText', { | ||
| defaultMessage: 'View alert in Kibana', | ||
| defaultMessage: 'View rule in Kibana', |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 28, 2021
elastic#100734) * Taking space id into account when creating email footer link * Handling undefined space when spaces is disabled * Handling undefined space when spaces is disabled Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 28, 2021
#100734) (#100913) * Taking space id into account when creating email footer link * Handling undefined space when spaces is disabled * Handling undefined space when spaces is disabled Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 28, 2021
* master: (77 commits) [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015) [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809) updating the saved objects test to include more saved object types (elastic#100828) [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789) Fixing ES archive mapping failure (elastic#100835) Fix bug with Observability > APM header navigation (elastic#100845) [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668) [Actions] Taking space id into account when creating email footer link (elastic#100734) Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823) [Security Solution] Improve find rule and find rule status route performance (elastic#99678) [DOCS] Adds video to introduction (elastic#100906) [Fleet] Improve combo box for fleet settings (elastic#100603) [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813) [DOCS] Adds Lens video (elastic#100898) [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765) chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810) [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718) [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864) [Lens] Adds dynamic table cell coloring (elastic#95217) [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99300
Summary
Passing in
spaceIdto the function that creates the footer link. IfspaceIdis not default, prepends/s/${spaceId}to the footer link.To Verify
Create a rule in the default space and in another space. Add an email action to both rules. Verify that the email received has a footer link that correctly resolves to the rule details page, including space id if required.
Checklist
Delete any items that are not applicable to this PR.