remove ui settings client-side validation

[pgayvallet]

Summary

Fix #83038

Remove the uiSettings legacy client-side validation

Checklist

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[mshustov]

Maybe we should test the value is a valid ByteSize ?

kibana/packages/kbn-config-schema/src/types/byte_size_type.ts

Line 23 in 812195f

export class ByteSizeType extends Type<ByteSizeValue> {

[flash1293]

Kibana app changes LGTM, validation for invalid JSON still works.

Can someone elaborate on why we are removing this from the client? It seems like useful UX because the user sees right away their input is invalid instead of trying to click an enabled save button which will cause an error.

The linked issue is pretty light on details.

I don't have a strong opinion on this - as you mentioned it's not used much anyway.

[mshustov]

Can someone elaborate on why we are removing this from the client? It seems like useful UX because the user sees right away their input is invalid instead of trying to click an enabled save button which will cause an error.

@flash1293 The client-side validation is not used for UI settings set via HTTP endpoints and kibana.yml, so we switched to the server-side validation. To avoid the situation when you have to keep the validation in sync for the client and server-side, we decided to remove the client-side validation, since UI can rely on the server-side validation.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2ec9426
• Storybooks Preview

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
core	998	984	-14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
advancedSettings	913.5KB	912.7KB	-830.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
core	29	26	-3

Unknown metric groups

API count

id	before	after	diff
core	2207	2187	-20

References to deprecated APIs

id	before	after	diff
canvas	29	25	-4
crossClusterReplication	8	6	-2
fleet	22	20	-2
globalSearch	4	2	-2
indexManagement	12	7	-5
infra	261	149	-112
lens	67	45	-22
licensing	18	15	-3
maps	286	208	-78
ml	121	115	-6
monitoring	109	56	-53
stackAlerts	101	95	-6
total			-295

History

• 💛 Build #126488 was flaky bcb9611
• 💔 Build #126487 failed c6fa590

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream